debug

hugodutka · hugodutka · commit f4d0f7b6fb27 · 2024-11-15T12:36:05.000Z
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -64,16 +64,20 @@ jobs:
               print("Success")
               with open(github_output, 'a') as output_file:
                   print(f'{output_name}=success', file=output_file)
+      # This is used by the `required` job to determine if the test-go-pg job
+      # failed or not on the given OS. Matrix jobs don't support `outputs`
+      # well - the last job to run overwrites them. Instead, we write to
+      # artifacts.
       - if: always()
-        run: echo "0" > "pg_result_${{ matrix.os }}"
+        run: echo "0" > "test-go-pg_result_${{ matrix.os }}"
       - if: failure()
-        run: echo "1" > "pg_result_${{ matrix.os }}"
+        run: echo "1" > "test-go-pg_result_${{ matrix.os }}"
       - name: Upload result artifact
         if: always()
         uses: actions/upload-artifact@v4
         with:
-          name: "pg_result_${{ matrix.os }}"
-          path: "pg_result_${{ matrix.os }}"
+          name: "test-go-pg_result_${{ matrix.os }}"
+          path: "test-go-pg_result_${{ matrix.os }}"
 
 
   required:
@@ -97,11 +101,11 @@ jobs:
         uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
         with:
           egress-policy: audit
-      - name: Download PG Failed Artifacts
+      - name: Download test-go-pg Artifacts
         uses: actions/download-artifact@v4
         with:
-          path: pg_result
-          pattern: pg_result_*
+          path: test-go-pg_result
+          pattern: test-go-pg_result_*
           merge-multiple: true
       - name: Ensure required checks
         shell: python
@@ -122,20 +126,18 @@ jobs:
           print()
 
           failed = False
-          print("all files")
-          print(list(Path(".").glob("*")))
           for job_name in job_names:
               result = jobs[job_name]["result"]
 
               # Skip test-go-pg failures on windows
               if job_name == "test-go-pg" and result == "failure":
-                  result_artifacts = list(Path("pg_result").glob("pg_result_*"))
-                  print("result_artifacts")
-                  print(result_artifacts)
+                  result_artifacts = list(Path("test-go-pg_result").glob("test-go-pg_result_*"))
                   results = {f.name: int(f.read_text()) for f in result_artifacts}
-                  del results["pg_result_windows-2022"]
+                  del results["test-go-pg_result_windows-2022"]
                   if sum(results.values()) == 0:
+                      print("test-go-pg on windows-2022 failed, but we are skipping it")
                       continue
+              
               if result in ["failure", "cancelled"]:
                   failed = True
                   break
