add built in role validation tests

Emyrk · Emyrk · commit f5cd901807ac · 2024-05-15T20:23:02.000-05:00
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/roles.sql b/coderd/database/queries/roles.sql
@@ -12,17 +12,17 @@ WHERE
 -- name: UpsertCustomRole :one
 INSERT INTO
 	custom_roles (
-		name,
+	    name,
 	    display_name,
-		site_permissions,
-	  	org_permissions,
-	  	user_permissions,
-		created_at,
+	    site_permissions,
+	    org_permissions,
+	    user_permissions,
+	    created_at,
 	    last_updted
 )
 VALUES (
         -- Always force lowercase names
-		lower(@name),
+        lower(@name),
         @display_name,
         @site_permissions,
         @org_permissions,
diff --git a/coderd/rbac/roles_test.go b/coderd/rbac/roles_test.go
@@ -20,6 +20,25 @@ type authSubject struct {
 	Actor rbac.Subject
 }
 
+func TestBuiltInRoles(t *testing.T) {
+	t.Parallel()
+	for _, r := range rbac.SiteRoles() {
+		r := r
+		t.Run(r.Name, func(t *testing.T) {
+			t.Parallel()
+			require.NoError(t, r.Valid(), "invalid role")
+		})
+	}
+
+	for _, r := range rbac.OrganizationRoles(uuid.New()) {
+		r := r
+		t.Run(r.Name, func(t *testing.T) {
+			t.Parallel()
+			require.NoError(t, r.Valid(), "invalid role")
+		})
+	}
+}
+
 //nolint:tparallel,paralleltest
 func TestOwnerExec(t *testing.T) {
 	owner := rbac.Subject{
