fix: handle task sidebar app health check disabled correctly (cherry-pick #18687) (#18726)

gcp-cherry-pick-bot[bot] · hugodutka · web-flow · commit f97bd76bb53b · 2025-07-02T13:14:55.000-05:00
Co-authored-by: Hugo Dutka &lt;hugo@coder.com&gt;
diff --git a/site/src/pages/TaskPage/TaskPage.stories.tsx b/site/src/pages/TaskPage/TaskPage.stories.tsx
@@ -113,7 +113,7 @@ export const TerminatedBuildWithStatus: Story = {
 	},
 };
 
-export const SidebarAppDisabled: Story = {
+export const SidebarAppHealthDisabled: Story = {
 	beforeEach: () => {
 		spyOn(data, "fetchTask").mockResolvedValue({
 			prompt: "Create competitors page",
diff --git a/site/src/pages/TaskPage/TaskSidebar.tsx b/site/src/pages/TaskPage/TaskSidebar.tsx
@@ -54,8 +54,10 @@ const getSidebarApp = (task: Task): [WorkspaceApp | null, SidebarAppStatus] => {
 		// indefinitely if there's a genuine issue, but this is preferable to false error alerts.
 		return [null, "loading"];
 	}
+	// "disabled" means that the health check is disabled, so we assume
+	// that the app is healthy
 	if (sidebarApp.health === "disabled") {
-		return [sidebarApp, "error"];
+		return [sidebarApp, "healthy"];
 	}
 	if (sidebarApp.health === "healthy") {
 		return [sidebarApp, "healthy"];

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,10 @@ const getSidebarApp = (task: Task): [WorkspaceApp \| null, SidebarAppStatus] => {`
`54`	`54`	`// indefinitely if there's a genuine issue, but this is preferable to false error alerts.`
`55`	`55`	`return [null, "loading"];`
`56`	`56`	`}`
	`57`	`+ // "disabled" means that the health check is disabled, so we assume`
	`58`	`+ // that the app is healthy`
`57`	`59`	`if (sidebarApp.health === "disabled") {`
`58`		`- return [sidebarApp, "error"];`
	`60`	`+ return [sidebarApp, "healthy"];`
`59`	`61`	`}`
`60`	`62`	`if (sidebarApp.health === "healthy") {`
`61`	`63`	`return [sidebarApp, "healthy"];`