handle zero input in testing

mafredri · mafredri · commit fa1ee2a58022 · 2025-01-15T12:13:43.000Z
diff --git a/coderd/provisionerjobs.go b/coderd/provisionerjobs.go
@@ -315,8 +315,11 @@ func convertProvisionerJob(pj database.GetProvisionerJobsByIDsWithQueuePositionR
 	}
 	job.Status = codersdk.ProvisionerJobStatus(pj.ProvisionerJob.JobStatus)
 
-	if err := json.Unmarshal(provisionerJob.Input, &job.Input); err != nil {
-		job.Input.Error = xerrors.Errorf("decode input: %w", err).Error()
+	// Only unmarshal input if it exists, this should only be zero in testing.
+	if len(provisionerJob.Input) > 0 {
+		if err := json.Unmarshal(provisionerJob.Input, &job.Input); err != nil {
+			job.Input.Error = xerrors.Errorf("decode input %s: %w", provisionerJob.Input, err).Error()
+		}
 	}
 
 	return job

Original file line number	Diff line number	Diff line change
`@@ -315,8 +315,11 @@ func convertProvisionerJob(pj database.GetProvisionerJobsByIDsWithQueuePositionR`
`315`	`315`	`}`
`316`	`316`	`job.Status = codersdk.ProvisionerJobStatus(pj.ProvisionerJob.JobStatus)`
`317`	`317`
`318`		`- if err := json.Unmarshal(provisionerJob.Input, &job.Input); err != nil {`
`319`		`- job.Input.Error = xerrors.Errorf("decode input: %w", err).Error()`
	`318`	`+ // Only unmarshal input if it exists, this should only be zero in testing.`
	`319`	`+ if len(provisionerJob.Input) > 0 {`
	`320`	`+ if err := json.Unmarshal(provisionerJob.Input, &job.Input); err != nil {`
	`321`	`+ job.Input.Error = xerrors.Errorf("decode input %s: %w", provisionerJob.Input, err).Error()`
	`322`	`+ }`
`320`	`323`	`}`
`321`	`324`
`322`	`325`	`return job`