Skip to content

Commit fd376ad

Browse files
committed
s/readAllUsers/viewAllUsers
Seems like all the other frontend variables use the `view` syntax. Arguably we should use `read` to match the backend, but `view` does seem more UI-like.
1 parent bf4b7ab commit fd376ad

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

site/src/contexts/auth/permissions.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
export const checks = {
2-
readAllUsers: "readAllUsers",
2+
viewAllUsers: "viewAllUsers",
33
updateUsers: "updateUsers",
44
createUser: "createUser",
55
createTemplates: "createTemplates",
@@ -15,7 +15,7 @@ export const checks = {
1515
} as const;
1616

1717
export const permissionsToCheck = {
18-
[checks.readAllUsers]: {
18+
[checks.viewAllUsers]: {
1919
object: {
2020
resource_type: "user",
2121
},

site/src/modules/dashboard/Navbar/Navbar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export const Navbar: FC = () => {
2121
const canViewOrganizations =
2222
featureVisibility.multiple_organizations &&
2323
experiments.includes("multi-organization");
24-
const canViewAllUsers = Boolean(permissions.readAllUsers);
24+
const canViewAllUsers = Boolean(permissions.viewAllUsers);
2525
const proxyContextValue = useProxy();
2626
const canViewHealth = canViewDeployment;
2727

site/src/testHelpers/entities.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2477,7 +2477,7 @@ export const MockPermissions: Permissions = {
24772477
createUser: true,
24782478
deleteTemplates: true,
24792479
updateTemplates: true,
2480-
readAllUsers: true,
2480+
viewAllUsers: true,
24812481
updateUsers: true,
24822482
viewAuditLog: true,
24832483
viewDeploymentValues: true,

0 commit comments

Comments
 (0)