s/readAllUsers/viewAllUsers

code-asher · code-asher · commit fd376adf160a · 2024-07-30T09:19:42.000-08:00
Seems like all the other frontend variables use the `view` syntax.
Arguably we should use `read` to match the backend, but `view` does seem
more UI-like.
diff --git a/site/src/contexts/auth/permissions.tsx b/site/src/contexts/auth/permissions.tsx
@@ -1,5 +1,5 @@
 export const checks = {
-  readAllUsers: "readAllUsers",
+  viewAllUsers: "viewAllUsers",
   updateUsers: "updateUsers",
   createUser: "createUser",
   createTemplates: "createTemplates",
@@ -15,7 +15,7 @@ export const checks = {
 } as const;
 
 export const permissionsToCheck = {
-  [checks.readAllUsers]: {
+  [checks.viewAllUsers]: {
     object: {
       resource_type: "user",
     },
diff --git a/site/src/modules/dashboard/Navbar/Navbar.tsx b/site/src/modules/dashboard/Navbar/Navbar.tsx
@@ -21,7 +21,7 @@ export const Navbar: FC = () => {
   const canViewOrganizations =
     featureVisibility.multiple_organizations &&
     experiments.includes("multi-organization");
-  const canViewAllUsers = Boolean(permissions.readAllUsers);
+  const canViewAllUsers = Boolean(permissions.viewAllUsers);
   const proxyContextValue = useProxy();
   const canViewHealth = canViewDeployment;
 
diff --git a/site/src/testHelpers/entities.ts b/site/src/testHelpers/entities.ts
@@ -2477,7 +2477,7 @@ export const MockPermissions: Permissions = {
   createUser: true,
   deleteTemplates: true,
   updateTemplates: true,
-  readAllUsers: true,
+  viewAllUsers: true,
   updateUsers: true,
   viewAuditLog: true,
   viewDeploymentValues: true,
