Skip to content

Support Go 1.22 #11342

Closed
Closed
@stefanb

Description

@stefanb

When trying

the build failed with

  # gvisor.dev/gvisor/pkg/sync
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/coder/gvisor@v0.0.0-20230714132058-be2e4ac102c3/pkg/sync/gate_unsafe.go:114:3: undefined: goready
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/coder/gvisor@v0.0.0-20230714132058-be2e4ac102c3/pkg/sync/gate_unsafe.go:144:2: undefined: gopark
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/coder/gvisor@v0.0.0-20230714132058-be2e4ac102c3/pkg/sync/rwmutex_unsafe.go:76:3: undefined: semacquire
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/coder/gvisor@v0.0.0-20230714132058-be2e4ac102c3/pkg/sync/rwmutex_unsafe.go:102:4: undefined: semrelease
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/coder/gvisor@v0.0.0-20230714132058-be2e4ac102c3/pkg/sync/rwmutex_unsafe.go:152:3: undefined: semacquire
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/coder/gvisor@v0.0.0-20230714132058-be2e4ac102c3/pkg/sync/rwmutex_unsafe.go:179:3: undefined: semrelease
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/coder/gvisor@v0.0.0-20230714132058-be2e4ac102c3/pkg/sync/rwmutex_unsafe.go:207:3: undefined: semrelease
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/coder/gvisor@v0.0.0-20230714132058-be2e4ac102c3/pkg/sync/seqcount.go:87:6: undefined: canSpin
  /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/coder/gvisor@v0.0.0-20230714132058-be2e4ac102c3/pkg/sync/seqcount.go:89:4: undefined: doSpin

The gvisor fork https://github.com/coder/gvisor that this project is using seems to be very different from upstream.

Upstream gvisor has support for Go 1.22:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions