Skip to content

refactor(site): move toggle favorites handler inside ToggleFavoriteButton #11892

Closed as not planned
@johnstcn

Description

@johnstcn
          It's an implicit convention, but when dealing with event handlers, we usually name them using the `on` prefix like `onSomething` instead of `handleSomething`. So instead of `handleActions`, I think a better name would be `onToggle`.

Also, you can move the query inside this button 😁. We're trying to put things close to where they're used.

Originally posted by @BrunoQuaresma in #11875 (comment)

Metadata

Metadata

Assignees

Labels

siteArea: frontend dashboardstaleThis issue is like stale bread.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions