Open
Description
Problem:
There are some inconsistencies in how we handle tar archives:
provisionersdk.Tar
adds symlinks without de-referencing themprovisionersdk.Untar
does not handle symlinks at all as far as I can tellprovisionerd
does not actually useprovisionersdk.Untar
to extract archives; it uses a separate implementation(*provisionersdk.Session).extractArchive()
Proposed solution:
- Bring the behaviour of
provisionersdk.Untar
in line withextractArchive()
- Replace existing usage of
extractArchive()
withprovisionersdk.Untar
- Clarify behaviour regarding symlinks -- given that we currently do not extract them, it does not make sense to continue the existing dereferencing behaviour in
provisionersdk.Tar()
.
Originally posted by @johnstcn in #16128 (comment)