Skip to content

Chore: Only run Chromatic on site changes #1695

Closed
@greyscaled

Description

@greyscaled

Overview

Right now Chromatic runs on every single commit. While this is great in terms of regression prevention, it's absolutely unnecessary for a lot of changes, which eats into our usage (we only get a certain number of builds per month), and possibly causes CI confusion for backend-oriented changes that don't related to the FE.

What should we visual regression test?

  • It's not adequate to simply check if ts,tsx files have changed: we need to run these tests on changes to embedded Go, dependencies updates and generated code as well.

AC

  • Filter for the site/ directory, with a useful comment that should the repository organization change, we change that filter appropriately.
  • An example change would be placing some node_modules in the root directory to share amongst subdirectories; we want visual regression testing on those as well

Metadata

Metadata

Assignees

Labels

siteArea: frontend dashboard

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions