Skip to content

Broken migration on v2 dogfood instance #2998

Closed
@AbhineetJain

Description

@AbhineetJain

Migration 000030_template_version_created_by.up.sql causes the following problem:

Jul 14 20:51:19 coder coder[29928]: 2022-07-14 20:51:19.062 [DEBUG]        (postgres.stdlib)        <./../../fergusstrange/embedded-postgres/logging.go:47>        (*syncedLogger).flush        ...
Jul 14 20:51:19 coder coder[29928]:   "msg": 2022-07-14 20:51:18.958 UTC [29945] ERROR:  column "created_by" of relation "template_versions" contains null values
Jul 14 20:51:19 coder coder[29928]:          2022-07-14 20:51:18.958 UTC [29945] STATEMENT:  ALTER TABLE ONLY template_versions ADD COLUMN IF NOT EXISTS created_by uuid REFERENCES users (id) ON DELETE RESTRICT;
Jul 14 20:51:19 coder coder[29928]:
Jul 14 20:51:19 coder coder[29928]:                  UPDATE
Jul 14 20:51:19 coder coder[29928]:                      template_versions
Jul 14 20:51:19 coder coder[29928]:                  SET
Jul 14 20:51:19 coder coder[29928]:                      created_by = (
Jul 14 20:51:19 coder coder[29928]:                          SELECT created_by FROM templates
Jul 14 20:51:19 coder coder[29928]:                          WHERE template_versions.template_id = templates.id
Jul 14 20:51:19 coder coder[29928]:                          LIMIT 1
Jul 14 20:51:19 coder coder[29928]:                      )
Jul 14 20:51:19 coder coder[29928]:                  WHERE
Jul 14 20:51:19 coder coder[29928]:                      created_by IS NULL;
Jul 14 20:51:19 coder coder[29928]:
Jul 14 20:51:19 coder coder[29928]:                  ALTER TABLE ONLY template_versions ALTER COLUMN created_by SET NOT NULL;
Jul 14 20:51:19 coder coder[29928]:
Jul 14 20:51:19 coder coder[29928]:          waiting for server to shut down....2022-07-14 20:51:18.961 UTC [29936] LOG:  received fast shutdown request
Jul 14 20:51:19 coder coder[29928]:          2022-07-14 20:51:18.967 UTC [29936] LOG:  aborting any active transactions
Jul 14 20:51:19 coder coder[29928]:          2022-07-14 20:51:18.967 UTC [29944] FATAL:  terminating connection due to administrator command
Jul 14 20:51:19 coder coder[29928]:          2022-07-14 20:51:18.968 UTC [29936] LOG:  background worker "logical replication launcher" (PID 29943) exited with exit code 1
Jul 14 20:51:19 coder coder[29928]:          2022-07-14 20:51:18.968 UTC [29945] FATAL:  terminating connection due to administrator command
Jul 14 20:51:19 coder coder[29928]:          2022-07-14 20:51:18.970 UTC [29938] LOG:  shutting down
Jul 14 20:51:19 coder coder[29928]:          2022-07-14 20:51:19.005 UTC [29936] LOG:  database system is shut down
Jul 14 20:51:19 coder coder[29928]:           done
Jul 14 20:51:19 coder coder[29928]:          server stopped
Jul 14 20:51:19 coder coder[29928]: migrate up: up: migration failed: column "created_by" of relation "template_versions" contains null values in line 0: ALTER TABLE ONLY template_versions ADD COLUMN IF NOT EXISTS created_by uuid REFERENCES users (id) ON DELETE RESTRICT;
Jul 14 20:51:19 coder coder[29928]:
Jul 14 20:51:19 coder coder[29928]: UPDATE
Jul 14 20:51:19 coder coder[29928]:     template_versions
Jul 14 20:51:19 coder coder[29928]: SET
Jul 14 20:51:19 coder coder[29928]:     created_by = (
Jul 14 20:51:19 coder coder[29928]:         SELECT created_by FROM templates
Jul 14 20:51:19 coder coder[29928]:         WHERE template_versions.template_id = templates.id
Jul 14 20:51:19 coder coder[29928]:         LIMIT 1
Jul 14 20:51:19 coder coder[29928]:     )
Jul 14 20:51:19 coder coder[29928]: WHERE
Jul 14 20:51:19 coder coder[29928]:     created_by IS NULL;
Jul 14 20:51:19 coder coder[29928]:
Jul 14 20:51:19 coder coder[29928]: ALTER TABLE ONLY template_versions ALTER COLUMN created_by SET NOT NULL;
Jul 14 20:51:19 coder coder[29928]:  (details: pq: column "created_by" of relation "template_versions" contains null values)
Jul 14 20:51:19 coder coder[29928]: Run 'coder server --help' for usage.

This has brought down https://dev.coder.com.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions