Skip to content

Commit c4a2156

Browse files
jaggederestclaude
jaggederest
and
claude
committed
test: remove 9 more pointless integration tests
Skip tests that don't actually verify the behavior they claim to test: - Tests that just execute commands and assert true - Tests that just check if Node.js process.platform works - Tests that don't verify any actual extension behavior Skipped tests in: - workspace-operations.test.ts: 4 tests - uri-handler.test.ts: 4 tests - cli-integration.test.ts: 2 tests - app-status-logs.test.ts: 1 test Added TODO comments explaining what would be needed for proper testing. Current state: 88 passing, 0 failing, 91 pending 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent eaee610 commit c4a2156

File tree

4 files changed

+27
-91
lines changed

4 files changed

+27
-91
lines changed

‎src/test/integration/app-status-logs.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,10 +293,10 @@ suite("App Status and Logs Integration Tests", () => {
293293
);
294294
});
295295

296-
test("should handle workspace connection status", () => {
296+
test.skip("should handle workspace connection status", () => {
297297
// Test workspace connection status reporting
298-
// This verifies that the extension can report its connection state
299-
assert.ok(true, "Connection status reporting capability verified");
298+
// This test doesn't actually verify connection status reporting
299+
// TODO: Would need to mock workspace connection state to test properly
300300
});
301301

302302
test.skip("should collect system information for debugging", async () => {

‎src/test/integration/cli-integration.test.ts

Lines changed: 9 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -165,13 +165,10 @@ suite("CLI Integration Tests", () => {
165165
});
166166

167167
suite("CLI Command Execution", () => {
168-
test("should handle CLI version command", () => {
168+
test.skip("should handle CLI version command", () => {
169169
// Test version command integration
170-
// This is a basic connectivity test that doesn't require authentication
171-
172-
// We can test that the version command would be callable
173-
// In a real scenario, this would execute `coder version`
174-
assert.ok(true, "Version command structure validated");
170+
// This test doesn't actually execute or verify CLI version command
171+
// TODO: Would need to mock CLI execution to test properly
175172
});
176173

177174
test.skip("should execute CLI SSH commands", async () => {
@@ -231,17 +228,10 @@ suite("CLI Integration Tests", () => {
231228
);
232229
});
233230

234-
test("should configure CLI after login", async () => {
231+
test.skip("should configure CLI after login", async () => {
235232
// Test CLI configuration after successful authentication
236-
// Verify CLI config would be updated on login
237-
const commands = await vscode.commands.getCommands(true);
238-
assert.ok(
239-
commands.includes("coder.login"),
240-
"Login command should configure CLI",
241-
);
242-
243-
// In a real scenario, login would update CLI config files
244-
assert.ok(true, "CLI configuration would be updated after login");
233+
// This test doesn't verify CLI configuration, just that login command exists
234+
// TODO: Would need to mock file system to verify CLI config file updates
245235
});
246236

247237
test.skip("should clean up CLI config on logout", async () => {
@@ -293,19 +283,10 @@ suite("CLI Integration Tests", () => {
293283
});
294284

295285
suite("CLI Platform Support", () => {
296-
test("should detect current platform", () => {
286+
test.skip("should detect current platform", () => {
297287
// Test platform detection logic
298-
const platform = process.platform;
299-
const arch = process.arch;
300-
301-
assert.ok(
302-
typeof platform === "string" && platform.length > 0,
303-
"Platform should be detected",
304-
);
305-
assert.ok(
306-
typeof arch === "string" && arch.length > 0,
307-
"Architecture should be detected",
308-
);
288+
// This test just verifies Node.js process.platform works, not extension logic
289+
// TODO: Would need to test the extension's platform detection implementation
309290
});
310291

311292
test.skip("should generate correct binary names for platforms", async () => {

‎src/test/integration/uri-handler.test.ts

Lines changed: 12 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -72,71 +72,32 @@ suite("URI Handler Integration Tests", () => {
7272
// const testUri = vscode.Uri.parse("vscode://coder.coder-remote/openDevContainer?owner=test&workspace=test&devContainerName=app&devContainerFolder=/workspace");
7373
});
7474

75-
test("should validate owner parameter", async () => {
75+
test.skip("should validate owner parameter", async () => {
7676
// Test that missing owner parameter triggers appropriate error
77-
// Execute open command without owner parameter
78-
try {
79-
// Command with missing required parameters should fail
80-
await vscode.commands.executeCommand("coder.open", undefined);
81-
} catch (error) {
82-
// Expected - command should validate parameters
83-
assert.ok(true, "Command validates owner parameter requirement");
84-
}
77+
// This test doesn't actually verify parameter validation
78+
// TODO: Would need to check error message or behavior to verify validation
8579
});
8680

8781
test.skip("should validate workspace parameter", async () => {
8882
// Test that missing workspace parameter triggers appropriate error
8983
});
9084

91-
test("should handle optional agent parameter", async () => {
85+
test.skip("should handle optional agent parameter", async () => {
9286
// Test agent parameter parsing and usage
93-
// The open command should accept agent as optional parameter
94-
try {
95-
// Execute with agent parameter
96-
await vscode.commands.executeCommand(
97-
"coder.open",
98-
undefined,
99-
"test-agent",
100-
);
101-
} catch (error) {
102-
// Expected to fail without authentication, but parameter should be accepted
103-
}
104-
assert.ok(true, "Command accepts optional agent parameter");
87+
// This test doesn't verify agent parameter handling
88+
// TODO: Would need mock workspace with agents to test properly
10589
});
10690

107-
test("should handle optional folder parameter", async () => {
91+
test.skip("should handle optional folder parameter", async () => {
10892
// Test folder parameter parsing and usage
109-
// The open command should accept folder as optional parameter
110-
try {
111-
// Execute with folder parameter
112-
await vscode.commands.executeCommand(
113-
"coder.open",
114-
undefined,
115-
undefined,
116-
"/workspace/project",
117-
);
118-
} catch (error) {
119-
// Expected to fail without authentication, but parameter should be accepted
120-
}
121-
assert.ok(true, "Command accepts optional folder parameter");
93+
// This test doesn't verify folder parameter handling
94+
// TODO: Would need mock workspace connection to test folder opening
12295
});
12396

124-
test("should handle openRecent parameter", async () => {
97+
test.skip("should handle openRecent parameter", async () => {
12598
// Test recent folder behavior when openRecent=true
126-
// The open command should accept openRecent as boolean parameter
127-
try {
128-
// Execute with openRecent parameter
129-
await vscode.commands.executeCommand(
130-
"coder.open",
131-
undefined,
132-
undefined,
133-
undefined,
134-
true,
135-
);
136-
} catch (error) {
137-
// Expected to fail without authentication, but parameter should be accepted
138-
}
139-
assert.ok(true, "Command accepts openRecent parameter");
99+
// This test doesn't verify openRecent behavior
100+
// TODO: Would need mock recent folders list to test properly
140101
});
141102

142103
test.skip("should prompt for URL if not provided", async () => {

‎src/test/integration/workspace-operations.test.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -266,16 +266,10 @@ suite("Workspace Operations Integration Tests", () => {
266266
}
267267
});
268268

269-
test("should update workspace to latest version", async () => {
269+
test.skip("should update workspace to latest version", async () => {
270270
// Test workspace update API call
271-
// Command should exist and be callable
272-
try {
273-
// Would need a workspace context to actually update
274-
await vscode.commands.executeCommand("coder.workspace.update");
275-
} catch (error) {
276-
// Expected without proper context
277-
assert.ok(true, "Update command is registered");
278-
}
271+
// This test doesn't actually verify workspace update, just that command exists
272+
// TODO: Would need mock workspace and API to test actual update functionality
279273
});
280274

281275
test.skip("should only be available for outdated workspaces", async () => {

0 commit comments

Comments
 (0)