Fix memory corruption when swapping URIs

csk-ableton · csk-ableton · commit ab3a3ac58ba7 · 2018-07-23T15:42:14.000+02:00
Simply swapping the string_view is not valid as std::basic_string::swap
might invalidate existing iterators and pointers.

I couldn't find a minimal test to reproduce it because it's unclear
when iterators are invalidated.
diff --git a/src/uri.cpp b/src/uri.cpp
@@ -195,7 +195,8 @@ uri &uri::operator=(uri other) {
 
 void uri::swap(uri &other) noexcept {
   uri_.swap(other.uri_);
-  uri_view_.swap(other.uri_view_);
+  uri_view_ = uri_;
+  other.uri_view_ = other.uri_;
 
   const auto this_parts = uri_parts_;
   detail::advance_parts(uri_view_, uri_parts_, other.uri_parts_);
