Track snapshot stats as metrics #130301
Draft
Track snapshot stats as metrics #130301
+686
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
serverless-linked
nicktindall
added
>non-issue
:Distributed Coordination/Snapshot/Restore
nicktindall
commented
Jun 30, 2025
| @@ -152,6 +156,7 @@ public RepositoriesService( | |||
| threadPool.relativeTimeInMillisSupplier() | |||
| ); | |||
| this.preRestoreChecks = preRestoreChecks; | |||
| this.snapshotMetrics = new SnapshotMetrics(meterRegistry, this::getSnapshotsInProgress); | |||
There was a problem hiding this comment.
We only create SnapshotMetrics here so we can provide it with the supplier for the "snapshots in progress" gauge. This means we need to pass it to the Repository.Factory#create call rather than the RepositoryPlugin#getRepositories.
nicktindall
commented
Jun 30, 2025
| ActionListener.running( | ||
| () -> blobStoreSnapshotMetrics.shardSnapshotCompleted(threadPool.absoluteTimeInMillis() - startTimeInMillis) | ||
| ) | ||
| ); |
There was a problem hiding this comment.
We track start and finish shard here, which means we don't include the time in the queue, we could move this to include time in the queue as well?
I think we'd want this time to reflect the amount of time shards are unable to be moved, I will dig in to see whether queued time or snapshotting time is a better reflection of that?
nicktindall
commented
Jun 30, 2025
| snapshotMetrics.snapshotsShardsCompletedCounter().increment(); | ||
| if (durationInMillis > 0) { | ||
| snapshotMetrics.snapshotShardsDurationHistogram().record(durationInMillis / 1_000f); | ||
| } |
There was a problem hiding this comment.
totalTime will be zero in some failure cases I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional snapshot metrics and publishes them via APM
Still a WIP, need to add some tests, need to add new metrics to node stats