Include default false change that I missed from #128426/

muan · muan · commit 25d82d97f790 · 2019-11-27T15:40:14.000-05:00
diff --git a/src/index.ts b/src/index.ts
@@ -17,9 +17,9 @@ class FilterInputElement extends HTMLElement {
     super()
     this.currentQuery = null
     this.filter = null
-    this.debounceInputChange = debounce(() => filterResults(this))
+    this.debounceInputChange = debounce(() => filterResults(this, true))
     this.boundFilterResults = () => {
-      filterResults(this)
+      filterResults(this, false)
     }
   }
 
@@ -68,7 +68,7 @@ class FilterInputElement extends HTMLElement {
   }
 }
 
-async function filterResults(filterInput: FilterInputElement, checkCurrentQuery: boolean = true) {
+async function filterResults(filterInput: FilterInputElement, checkCurrentQuery: boolean = false) {
   const input = filterInput.input
   if (!input) return
   const query = input.value.toLowerCase()
diff --git a/test/test.js b/test/test.js
@@ -27,7 +27,6 @@ describe('filter-input', function() {
             <li>Hubot</li>
             <li>Wall-E</li>
             <li>BB-8</li>
-            <li>R2-D2</li>
           </ul>
           <p data-filter-empty-state hidden>0 robots found.</p>
         </div>
@@ -51,7 +50,7 @@ describe('filter-input', function() {
       assert.equal(results.length, 1)
       assert.equal(results[0].textContent, 'Hubot')
       assert.equal(customEvent.detail.count, 1)
-      assert.equal(customEvent.detail.total, 5)
+      assert.equal(customEvent.detail.total, 4)
       changeValue(input, 'boom')
       assert.notOk(emptyState.hidden, 'Empty state should be shown')
     })
@@ -64,10 +63,28 @@ describe('filter-input', function() {
       changeValue(input, ':)')
       const customEvent = await listener
       const results = Array.from(list.children).filter(el => !el.hidden)
-      assert.equal(results.length, 3)
+      assert.equal(results.length, 2)
       assert.equal(results[0].textContent, 'Wall-E')
-      assert.equal(customEvent.detail.count, 3)
-      assert.equal(customEvent.detail.total, 5)
+      assert.equal(customEvent.detail.count, 2)
+      assert.equal(customEvent.detail.total, 4)
+    })
+
+    it('filters again with the same value when a change event is fired', async function() {
+      const listener = once('filter-input-updated')
+      changeValue(input, '-')
+      const customEvent = await listener
+      assert.equal(customEvent.detail.count, 2)
+      assert.equal(customEvent.detail.total, 4)
+
+      const newRobot = document.createElement('li')
+      newRobot.textContent = 'R2-D2'
+      list.append(newRobot)
+
+      const listener2 = once('filter-input-updated')
+      changeValue(input, '-')
+      const customEvent2 = await listener2
+      assert.equal(customEvent2.detail.count, 3)
+      assert.equal(customEvent2.detail.total, 5)
     })
   })
 })

Original file line number	Diff line number	Diff line change
`@@ -17,9 +17,9 @@ class FilterInputElement extends HTMLElement {`
`17`	`17`	`super()`
`18`	`18`	`this.currentQuery = null`
`19`	`19`	`this.filter = null`
`20`		`- this.debounceInputChange = debounce(() => filterResults(this))`
	`20`	`+ this.debounceInputChange = debounce(() => filterResults(this, true))`
`21`	`21`	`this.boundFilterResults = () => {`
`22`		`- filterResults(this)`
	`22`	`+ filterResults(this, false)`
`23`	`23`	`}`
`24`	`24`	`}`
`25`	`25`
`@@ -68,7 +68,7 @@ class FilterInputElement extends HTMLElement {`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`
`71`		`-async function filterResults(filterInput: FilterInputElement, checkCurrentQuery: boolean = true) {`
	`71`	`+async function filterResults(filterInput: FilterInputElement, checkCurrentQuery: boolean = false) {`
`72`	`72`	`const input = filterInput.input`
`73`	`73`	`if (!input) return`
`74`	`74`	`const query = input.value.toLowerCase()`