fix issue with pagination in search_repositories

juruen · juruen · commit 4e88e657116d · 2025-04-05T16:37:10.000+02:00
diff --git a/pkg/github/search.go b/pkg/github/search.go
@@ -36,7 +36,7 @@ func searchRepositories(client *github.Client, t translations.TranslationHelperF
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-			perPage, err := optionalIntParamWithDefault(request, "per_page", 30)
+			perPage, err := optionalIntParamWithDefault(request, "perPage", 30)
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
diff --git a/pkg/github/search_test.go b/pkg/github/search_test.go
@@ -99,6 +99,28 @@ func Test_SearchRepositories(t *testing.T) {
 			expectError:    false,
 			expectedResult: mockSearchResult,
 		},
+		{
+			name: "repository search with custom pagination",
+			mockedClient: mock.NewMockedHTTPClient(
+				mock.WithRequestMatchHandler(
+					mock.GetSearchRepositories,
+					expectQueryParams(t, map[string]string{
+						"q":        "golang test",
+						"page":     "2",
+						"per_page": "5",
+					}).andThen(
+						mockResponse(t, http.StatusOK, mockSearchResult),
+					),
+				),
+			),
+			requestArgs: map[string]interface{}{
+				"query":   "golang test",
+				"page":    float64(2),
+				"perPage": float64(5),
+			},
+			expectError:    false,
+			expectedResult: mockSearchResult,
+		},
 		{
 			name: "search fails",
 			mockedClient: mock.NewMockedHTTPClient(

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ func searchRepositories(client *github.Client, t translations.TranslationHelperF`
`36`	`36`	`if err != nil {`
`37`	`37`	`return mcp.NewToolResultError(err.Error()), nil`
`38`	`38`	`}`
`39`		`- perPage, err := optionalIntParamWithDefault(request, "per_page", 30)`
	`39`	`+ perPage, err := optionalIntParamWithDefault(request, "perPage", 30)`
`40`	`40`	`if err != nil {`
`41`	`41`	`return mcp.NewToolResultError(err.Error()), nil`
`42`	`42`	`}`