Skip to content

_requestAllPages pagination is broken #569

Closed
@connorjclark

Description

@connorjclark

if (nextUrl && !(options && typeof options.page !== 'number')) {

This bit:

typeof options.page !== 'number'

can never be true, as the api functions (well, at least the one I need, listStarredRepos) don't allow for passing in options. Besides, it doesn't make much sense, I think it should be negated?

I have this line in my build script to bypass this issue:

sed -i '' "s/typeof options.page !== 'number'/false/g" dist/scripts/GitHub.bundle.js

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions