Skip to content

Better handling of raw bytes #346

Open
@broady

Description

@broady

Given this field in a discovery doc:

    "AsymmetricDecryptRequest": {
      "description": "Request message for KeyManagementService.AsymmetricDecrypt.",
      "id": "AsymmetricDecryptRequest",
      "properties": {
        "ciphertext": {
          "description": "Required. The data encrypted with the named CryptoKeyVersion's public\nkey using OAEP.",
          "format": "byte",
          "type": "string"
        }
      },
      "type": "object"
    },

This gets generated as:

type AsymmetricDecryptRequest struct {
    // Ciphertext: Required. The data encrypted with the named
    // CryptoKeyVersion's public
    // key using OAEP.
    Ciphertext string `json:"ciphertext,omitempty"`

The server accepts a base64-encoded string as the data, but we don't tell users that they need to encode it themselves.

Ideally, we'd just generate this as []byte, which encoding/json actually encodes as a b64-encoded string.

Is this a worthwhile breaking change?

If not, we should at least generate some docs/example on base64-encoding the package?

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions