Rebase #58 and add tests #159
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eg: the JSON string "\ud841\udf31" should contain the character with the unicode scalar value U+20731, not U+10731
DimitriPapadopoulos
force-pushed
the
bogbert
branch
5 times, most recently
from
2e7803f to
a2283bd
Compare
json.c: In function ‘json_parse_ex’:
json.c:359:42: error: suggest parentheses around arithmetic in operand of ‘|’ [-Werror=parentheses]
359 | uchar = 0x010000 + ((uchar & 0x3FF) << 10) | (uchar2 & 0x3FF);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
DimitriPapadopoulos
force-pushed
the
bogbert
branch
from
a2283bd to
4f4a664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #58.