Skip to content

LibGit2SharpException loses information in HandleError #2159

Closed
@asinghmodesttree

Description

@asinghmodesttree

In Ensure.HandleError function, since we do not have an exception for handling network errors, when fetch fails and the exception of type LibGit2SharpException exception is thrown, its thrown with arguments (Message, GitErrorCategory) but the exception doesn't have constructor that take an argument of type GitErrorCategory and the closest match is object params which is to handle string format arguments for messages, so the GitErrorCategory information is lost.

File: Ensure.cs:151 new LibGit2SharpException(m, c)

I am trying to understand if there is any technical reason it is done this way?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions