Skip to content

[MNT]: use to_numpy more #21036

Open
Open
@jklymak

Description

@jklymak

Summary

Both pandas and xarray now have a to_numpy method on their data objects. We only use to_numpy once in cbook._reshape_2D, and instead usually check .values. We probably should be using to_numpy more if that is indeed the new idiom for converting?

Ping @shoyer for xarray and @TomAugspurger for pandas, though please feel free to redirect as appropriate, you are being picked upon because you've interacted with us before 😉.

One thing I note for to_numpy and dates is that it does not seem to convert to numpy datetime64 or timedelta64 for either package - it'd be nice if they did!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions