Yes, I believe this is correct; HandlerBase.update_prop will set the correct figure (via Legend._set_artist_props), HandlerPolyCollection._update_prop exists to do the class-specific work of pulling the properties from the first artist in a collection and doesn't need to set the figure.

This could do with a test though.

Seems right to me too. The legend and the artists it contains (e.g. legend_handle here) are on the root Figure, whereas orig_handle is on the SubFigure, so they should not match.