-
Notifications
You must be signed in to change notification settings - Fork 8
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: microsoft/mssql-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: microsoft/mssql-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bewithgaurav/build_macos
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 5 files changed
- 1 contributor
Commits on Jun 18, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 2fc1d3c - Browse repository at this point
Copy the full SHA 2fc1d3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f1b4c6 - Browse repository at this point
Copy the full SHA 1f1b4c6View commit details
Commits on Jun 19, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 2d8a1e3 - Browse repository at this point
Copy the full SHA 2d8a1e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85ab851 - Browse repository at this point
Copy the full SHA 85ab851View commit details -
Configuration menu - View commit details
-
Copy full SHA for 674a0bf - Browse repository at this point
Copy the full SHA 674a0bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d6e173 - Browse repository at this point
Copy the full SHA 0d6e173View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55c2729 - Browse repository at this point
Copy the full SHA 55c2729View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25ec9f2 - Browse repository at this point
Copy the full SHA 25ec9f2View commit details -
FEAT: Universal Mac Builds - Unified WHL for ARM64 and Intel (#86)
### Summary <!-- Briefly describe the new feature --> This pull request introduces changes to standardize macOS builds by adopting the "universal2" architecture, which supports both `arm64` and `x86_64`. The updates simplify the build process, ensure consistency across tools, and improve compatibility. Key changes include modifications to the CMake configuration, build scripts, and Python packaging setup. ### macOS Build Standardization: * [`mssql_python/pybind/CMakeLists.txt`](diffhunk://#diff-dbb5892fbbb28149d1639664797cf3adb48ced28ec11aba95f2e2b338ca46badL31-R32): Replaced architecture-specific logic with a universal2 configuration for macOS, setting `ARCHITECTURE` to "universal2" and ensuring `CMAKE_OSX_ARCHITECTURES` is set to `arm64;x86_64`. Updated `WHEEL_ARCH` to "universal2" for macOS builds. [[1]](diffhunk://#diff-dbb5892fbbb28149d1639664797cf3adb48ced28ec11aba95f2e2b338ca46badL31-R32) [[2]](diffhunk://#diff-dbb5892fbbb28149d1639664797cf3adb48ced28ec11aba95f2e2b338ca46badR43-R48) [[3]](diffhunk://#diff-dbb5892fbbb28149d1639664797cf3adb48ced28ec11aba95f2e2b338ca46badL72-R70) * [`mssql_python/pybind/build.sh`](diffhunk://#diff-7cfcd9b5499a176c28ca4d028e9b2b060238ec79c4bea5b062d4b39929f9fb04L2-R31): Simplified the macOS build script by removing architecture-specific handling and ensuring the build process defaults to creating universal2 binaries. Added diagnostics to verify the resulting binary. [[1]](diffhunk://#diff-7cfcd9b5499a176c28ca4d028e9b2b060238ec79c4bea5b062d4b39929f9fb04L2-R31) [[2]](diffhunk://#diff-7cfcd9b5499a176c28ca4d028e9b2b060238ec79c4bea5b062d4b39929f9fb04L87-R85) ### Python Packaging Updates: * [`setup.py`](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7L41-R44): Updated macOS-specific logic to always use the "universal2" platform tag (`macosx_15_0_universal2`) for wheel packaging. Removed architecture detection and replaced it with a unified configuration. [[1]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7L41-R44) [[2]](diffhunk://#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7L75-R78) These changes streamline the macOS build process, reduce complexity, and ensure compatibility with both Apple Silicon and Intel-based Macs. ### Issue Reference Fixes [AB#37761](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/37761) ### Checklist - [x] **Tests Passed** (if applicable) - [x] **Code is formatted** - [x] **Docs Updated** (if necessary) ### Testing Performed <!-- How was this fix tested? --> - [x] Unit Tests ### Additional Notes <!-- Any extra details or related links -->
Configuration menu - View commit details
-
Copy full SHA for 8e10c7d - Browse repository at this point
Copy the full SHA 8e10c7dView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...bewithgaurav/build_macos