Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: modelcontextprotocol/typescript-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: modelcontextprotocol/typescript-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ochafik/auth-prm-check
Choose a head ref
  • 5 commits
  • 3 files changed
  • 2 contributors

Commits on Jun 17, 2025

  1. client: require that the resource returned by PRM matches the server … 

    …resource
    @ochafik
    ochafik committed Jun 17, 2025
    Configuration menu
    Copy the full SHA
    5b63dd6 View commit details
    Browse the repository at this point in the history

  2. auth: respect full resourceMetadataUrl url, and pass protocolVersion … 

    …through
    @ochafik
    ochafik committed Jun 17, 2025
    Configuration menu
    Copy the full SHA
    bb23147 View commit details
    Browse the repository at this point in the history

  3. test: add comprehensive tests for protocol version propagation and re… 

    …sourceMetadataUrl functionality

This commit adds 21 new comprehensive test cases to verify the OAuth authentication
enhancements from commit bb23147, covering:

1. Protocol Version Propagation Tests:
   - Custom protocol version headers in protected resource metadata discovery
   - Custom protocol version headers in OAuth metadata discovery
   - Default protocol version usage when not specified
   - CORS fallback behavior with protocol versions
   - Protocol version propagation through full auth flow

2. Custom Resource Metadata URL Tests:
   - Custom URL routing instead of default well-known locations
   - Custom URLs combined with protocol version headers
   - Various URL format handling (ports, query params, fragments, localhost)
   - CORS fallback with custom URLs

3. Integration Tests:
   - Resource validation working correctly with new parameters
   - Fallback behavior when metadata fails
   - Token exchange flow with protocol version propagation
   - Token refresh flow with protocol version propagation
   - All parameters working together in complex scenarios

4. Edge Case Tests:
   - Edge case protocol versions (old dates, future dates, suffixes, empty strings)
   - Various custom URL formats (ports, query params, fragments, localhost)
   - Combined CORS fallback scenarios

All tests maintain compatibility with existing functionality and ensure no regressions.
Fixed duplicate variable declaration issue in auth.ts discovered during testing.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
    @ochafik @claude
    ochafik and claude committed Jun 17, 2025
    Configuration menu
    Copy the full SHA
    eec52f5 View commit details
    Browse the repository at this point in the history

  4. test: simplify resource matching validation tests to bare minimum 

    Reduced the RFC 9728 resource matching validation test group to only test
the core functionality from commit 5b63dd6:
- Test for accepting matching resources
- Test for rejecting mismatched resources
- Test for rejecting missing resource field
- Test for fragment canonicalization during comparison

Removed extensive edge case testing to focus on the essential validation logic.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
    @ochafik @claude
    ochafik and claude committed Jun 17, 2025
    Configuration menu
    Copy the full SHA
    a5cab16 View commit details
    Browse the repository at this point in the history

  5. Update README.md

    @ochafik
    ochafik committed Jun 17, 2025
    Configuration menu
    Copy the full SHA
    7b073bf View commit details
    Browse the repository at this point in the history
Loading