tests: Cope with io_method in TEMP_CONFIG in test_aio

anarazel · anarazel · commit 327d987df1e7 · 2025-04-02T07:00:40.000-04:00
If io_method is set in TEMP_CONFIG the test added in 93bc3d7 fails, because it assumes the io_method specified at initdb is actually used. Fix that by appending the io_method again, after initdb (and thus after TEMP_CONFIG has been added by Cluster.pm). Per buildfarm animal bumblebee Discussion: https://postgr.es/m/zh5u22wbpcyfw2ddl3lsvmsxf4yvsrvgxqwwmfjddc4c2khsgp@gfysyjsaelr5
diff --git a/src/test/modules/test_aio/t/001_aio.pl b/src/test/modules/test_aio/t/001_aio.pl
@@ -94,6 +94,17 @@ sub create_node
 log_error_verbosity=default
 restart_after_crash=false
 temp_buffers=100
+));
+
+	# Even though we used -c io_method=... above, if TEMP_CONFIG sets
+	# io_method, it'd override the setting persisted at initdb time. While
+	# using (and later verifying) the setting from initdb provides some
+	# verification of having used the io_method during initdb, it's probably
+	# not worth the complication of only appending if the variable is set in
+	# in TEMP_CONFIG.
+	$node->append_conf(
+		'postgresql.conf', qq(
+io_method=$io_method
 ));
 
 	ok(1, "$io_method: initdb");
