Skip to content

Commit 3431e3e

Browse files
committed
pgbench: Use standard option handling test routines
Run program_XXX tests instead of its own tests. This ensures consistency with the test suites of other programs and enforces common policies, such as help line length. Author: Hayato Kuroda <kuroda.hayato@fujitsu.com> Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com> Discussion: https://www.postgresql.org/message-id/flat/OSCPR01MB14966247015B7E3D8D340D022F56FA@OSCPR01MB14966.jpnprd01.prod.outlook.com
1 parent 2e640a0 commit 3431e3e

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

src/bin/pgbench/t/002_pgbench_no_server.pl

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -233,21 +233,9 @@ sub pgbench_scripts
233233
'pgbench option error: ' . $name);
234234
}
235235

236-
# Help
237-
pgbench(
238-
'--help', 0,
239-
[
240-
qr{benchmarking tool for PostgreSQL},
241-
qr{Usage},
242-
qr{Initialization options:},
243-
qr{Common options:},
244-
qr{Report bugs to}
245-
],
246-
[qr{^$}],
247-
'pgbench help');
248-
249-
# Version
250-
pgbench('-V', 0, [qr{^pgbench .PostgreSQL. }], [qr{^$}], 'pgbench version');
236+
program_help_ok('pgbench');
237+
program_version_ok('pgbench');
238+
program_options_handling_ok('pgbench');
251239

252240
# list of builtins
253241
pgbench(

0 commit comments

Comments
 (0)