Skip to content

Commit 5ba00e1

Browse files
committed
Align log_line_prefix in CI and TAP tests with pg_regress.c
log_line_prefix is changed to include "%b", the backend type in the TAP test configuration. %v and %x are removed from the CI configuration, with the format around %b changed. The lack of backend type in postgresql.conf set by Cluster.pm for the TAP test configuration was something that has been bugging me, beginning the discussion that has led to this change. The change in the CI has come up during the discussion, to become consistent with pg_regress.c, %v and %x not being that useful to have. Reviewed-by: Andres Freund <andres@anarazel.de> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/aC0VaIWAXLgXcHVP@paquier.xyz
1 parent 2652835 commit 5ba00e1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/test/perl/PostgreSQL/Test/Cluster.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,7 @@ sub init
684684
print $conf "\n# Added by PostgreSQL::Test::Cluster.pm\n";
685685
print $conf "fsync = off\n";
686686
print $conf "restart_after_crash = off\n";
687-
print $conf "log_line_prefix = '%m [%p] %q%a '\n";
687+
print $conf "log_line_prefix = '%m %b[%p] %q%a '\n";
688688
print $conf "log_statement = all\n";
689689
print $conf "log_replication_commands = on\n";
690690
print $conf "wal_retrieve_retry_interval = '500ms'\n";

src/tools/ci/pg_ci_base.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ log_autovacuum_min_duration = 0
1010
log_checkpoints = true
1111
log_connections = all
1212
log_disconnections = true
13-
log_line_prefix = '%m [%p][%b] %q[%a][%v:%x] '
13+
log_line_prefix = '%m %b[%p] %q%a '
1414
log_lock_waits = true

0 commit comments

Comments
 (0)