Remove implicit cast from 'void *'

j-naylor · j-naylor · commit 9adb58a3ccb5 · 2025-07-02T11:51:10.000+07:00
Commit e2809e3 added code to a header which assigns a pointer to void to a pointer to unsigned char. This causes build errors for extensions written in C++. Fix by adding an explicit cast. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CANWCAZaCq9AHBuhs%3DMx7Gg_0Af9oRU7iAqr0itJCtfmsWwVmnQ%40mail.gmail.com Backpatch-through: 18
diff --git a/src/include/port/pg_crc32c.h b/src/include/port/pg_crc32c.h
@@ -72,7 +72,7 @@ pg_comp_crc32c_dispatch(pg_crc32c crc, const void *data, size_t len)
 {
 	if (__builtin_constant_p(len) && len < 32)
 	{
-		const unsigned char *p = data;
+		const unsigned char *p = (const unsigned char *) data;
 
 		/*
 		 * For small constant inputs, inline the computation to avoid a

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ pg_comp_crc32c_dispatch(pg_crc32c crc, const void *data, size_t len)`
`72`	`72`	`{`
`73`	`73`	`if (__builtin_constant_p(len) && len < 32)`
`74`	`74`	`{`
`75`		`- const unsigned char *p = data;`
	`75`	`+ const unsigned char p = (const unsigned char ) data;`
`76`	`76`
`77`	`77`	`/*`
`78`	`78`	`* For small constant inputs, inline the computation to avoid a`