Properly terminate the array returned by GetLockConflicts().

anarazel · anarazel · commit 059f30c1b1af · 2015-01-29T22:48:46.000+01:00
GetLockConflicts() has for a long time not properly terminated the
returned array. During normal processing the returned array is zero
initialized which, while not pretty, is sufficient to be recognized as
a invalid virtual transaction id. But the HotStandby case is more than
aesthetically broken: The allocated (and reused) array is neither
zeroed upon allocation, nor reinitialized, nor terminated.

Not having a terminating element means that the end of the array will
not be recognized and that recovery conflict handling will thus read
ahead into adjacent memory. Only terminating when hitting memory
content that looks like a invalid virtual transaction id.  Luckily
this seems so far not have caused significant problems, besides making
recovery conflict more expensive.

Discussion: 20150127142713.GD29457@awork2.anarazel.de

Backpatch into all supported branches.
diff --git a/src/backend/storage/lmgr/lock.c b/src/backend/storage/lmgr/lock.c
@@ -1944,6 +1944,8 @@ GetLockConflicts(const LOCKTAG *locktag, LOCKMODE lockmode)
 		 * on this lockable object.
 		 */
 		LWLockRelease(partitionLock);
+		vxids[count].backendId = InvalidBackendId;
+		vxids[count].localTransactionId = InvalidLocalTransactionId;
 		return vxids;
 	}
 
@@ -1989,6 +1991,8 @@ GetLockConflicts(const LOCKTAG *locktag, LOCKMODE lockmode)
 	if (count > MaxBackends)	/* should never happen */
 		elog(PANIC, "too many conflicting locks found");
 
+	vxids[count].backendId = InvalidBackendId;
+	vxids[count].localTransactionId = InvalidLocalTransactionId;
 	return vxids;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1944,6 +1944,8 @@ GetLockConflicts(const LOCKTAG *locktag, LOCKMODE lockmode)`
`1944`	`1944`	`* on this lockable object.`
`1945`	`1945`	`*/`
`1946`	`1946`	`LWLockRelease(partitionLock);`
	`1947`	`+ vxids[count].backendId = InvalidBackendId;`
	`1948`	`+ vxids[count].localTransactionId = InvalidLocalTransactionId;`
`1947`	`1949`	`return vxids;`
`1948`	`1950`	`}`
`1949`	`1951`
`@@ -1989,6 +1991,8 @@ GetLockConflicts(const LOCKTAG *locktag, LOCKMODE lockmode)`
`1989`	`1991`	`if (count > MaxBackends) /* should never happen */`
`1990`	`1992`	`elog(PANIC, "too many conflicting locks found");`
`1991`	`1993`
	`1994`	`+ vxids[count].backendId = InvalidBackendId;`
	`1995`	`+ vxids[count].localTransactionId = InvalidLocalTransactionId;`
`1992`	`1996`	`return vxids;`
`1993`	`1997`	`}`
`1994`	`1998`