Do not use an empty hostname.

Michael Meskes · Michael Meskes · commit 17bcdd01f361 · 2014-01-01T12:44:44.000+01:00
When trying to connect to a given database libecpg should not try using an
empty hostname if no hostname was given.
diff --git a/src/interfaces/ecpg/ecpglib/connect.c b/src/interfaces/ecpg/ecpglib/connect.c
@@ -326,7 +326,7 @@ ECPGconnect(int lineno, int c, const char *name, const char *user, const char *p
 
 	if (dbname != NULL)
 	{
-		/* get the detail information out of dbname */
+		/* get the detail information from dbname */
 		if (strncmp(dbname, "tcp:", 4) == 0 || strncmp(dbname, "unix:", 5) == 0)
 		{
 			int			offset = 0;
@@ -345,7 +345,7 @@ ECPGconnect(int lineno, int c, const char *name, const char *user, const char *p
 				/*------
 				 * new style:
 				 *	<tcp|unix>:postgresql://server[:port|:/unixsocket/path:]
-				 *	[/db name][?options]
+				 *	[/db-name][?options]
 				 *------
 				 */
 				offset += strlen("postgresql://");
@@ -420,8 +420,10 @@ ECPGconnect(int lineno, int c, const char *name, const char *user, const char *p
 					}
 				}
 				else
-					host = ecpg_strdup(dbname + offset, lineno);
-
+				{
+					if (*(dbname + offset) != '\0')
+						host = ecpg_strdup(dbname + offset, lineno);
+				}
 			}
 		}
 		else

Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,7 @@ ECPGconnect(int lineno, int c, const char name, const char user, const char *p`
`326`	`326`
`327`	`327`	`if (dbname != NULL)`
`328`	`328`	`{`
`329`		`- /* get the detail information out of dbname */`
	`329`	`+ /* get the detail information from dbname */`
`330`	`330`	`if (strncmp(dbname, "tcp:", 4) == 0 \|\| strncmp(dbname, "unix:", 5) == 0)`
`331`	`331`	`{`
`332`	`332`	`int offset = 0;`
`@@ -345,7 +345,7 @@ ECPGconnect(int lineno, int c, const char name, const char user, const char *p`
`345`	`345`	`/*------`
`346`	`346`	`* new style:`
`347`	`347`	`* <tcp\|unix>:postgresql://server[:port\|:/unixsocket/path:]`
`348`		`- * [/db name][?options]`
	`348`	`+ * [/db-name][?options]`
`349`	`349`	`*------`
`350`	`350`	`*/`
`351`	`351`	`offset += strlen("postgresql://");`
`@@ -420,8 +420,10 @@ ECPGconnect(int lineno, int c, const char name, const char user, const char *p`
`420`	`420`	`}`
`421`	`421`	`}`
`422`	`422`	`else`
`423`		`- host = ecpg_strdup(dbname + offset, lineno);`
`424`		`-`
	`423`	`+ {`
	`424`	`+ if (*(dbname + offset) != '\0')`
	`425`	`+ host = ecpg_strdup(dbname + offset, lineno);`
	`426`	`+ }`
`425`	`427`	`}`
`426`	`428`	`}`
`427`	`429`	`else`