Give a proper error message if initdb password file is empty.

hlinnaka · hlinnaka · commit 729202754e06 · 2014-12-05T14:31:37.000+02:00
Used to say just "could not read password from file "...": Success", which
isn't very informative.

Mats Erik Andersson. Backpatch to all supported versions.
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -1292,8 +1292,12 @@ get_set_pwd(void)
 		}
 		if (!fgets(pwdbuf, sizeof(pwdbuf), pwf))
 		{
-			fprintf(stderr, _("%s: could not read password from file \"%s\": %s\n"),
-					progname, pwfilename, strerror(errno));
+			if (ferror(pwf))
+				fprintf(stderr, _("%s: could not read password from file \"%s\": %s\n"),
+						progname, pwfilename, strerror(errno));
+			else
+				fprintf(stderr, _("%s: password file \"%s\" is empty\n"),
+						progname, pwfilename);
 			exit_nicely();
 		}
 		fclose(pwf);

Original file line number	Diff line number	Diff line change
`@@ -1292,8 +1292,12 @@ get_set_pwd(void)`
`1292`	`1292`	`}`
`1293`	`1293`	`if (!fgets(pwdbuf, sizeof(pwdbuf), pwf))`
`1294`	`1294`	`{`
`1295`		`- fprintf(stderr, _("%s: could not read password from file \"%s\": %s\n"),`
`1296`		`- progname, pwfilename, strerror(errno));`
	`1295`	`+ if (ferror(pwf))`
	`1296`	`+ fprintf(stderr, _("%s: could not read password from file \"%s\": %s\n"),`
	`1297`	`+ progname, pwfilename, strerror(errno));`
	`1298`	`+ else`
	`1299`	`+ fprintf(stderr, _("%s: password file \"%s\" is empty\n"),`
	`1300`	`+ progname, pwfilename);`
`1297`	`1301`	`exit_nicely();`
`1298`	`1302`	`}`
`1299`	`1303`	`fclose(pwf);`