Skip to content

Commit c6d43ff

Browse files
tglsfdctglsfdc
committed
Replace use of sys_siglist[] with strsignal().
This commit back-patches the v12-era commits a73d083, cc92cca, and 7570df0 into supported pre-v12 branches. The net effect is to eliminate our former dependency on the never-standard sys_siglist[] array, instead using POSIX-standard strsignal(3). What motivates doing this now is that glibc just removed sys_siglist[] from the set of symbols available to newly-built programs. While our code can survive without sys_siglist[], it then fails to print any description of the signal that killed a child process, which is a non-negligible loss of friendliness. We can expect that people will be wanting to build the back branches on platforms that include this change, so we need to do something. Since strsignal(3) has existed for quite a long time, and we've not had any trouble with these patches so far in v12, it seems safe to back-patch into older branches. Discussion: https://postgr.es/m/3179114.1594853308@sss.pgh.pa.us
1 parent c6d33d1 commit c6d43ff

File tree

12 files changed

+94
-84
lines changed

12 files changed

+94
-84
lines changed

‎configure

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -15004,7 +15004,7 @@ fi
1500415004
LIBS_including_readline="$LIBS"
1500515005
LIBS=`echo "$LIBS" | sed -e 's/-ledit//g' -e 's/-lreadline//g'`
1500615006

15007-
for ac_func in cbrt clock_gettime dlopen fdatasync getifaddrs getpeerucred getrlimit mbstowcs_l memmove poll posix_fallocate pstat pthread_is_threaded_np readlink setproctitle setsid shm_open symlink sync_file_range uselocale utime utimes wcstombs_l
15007+
for ac_func in cbrt clock_gettime dlopen fdatasync getifaddrs getpeerucred getrlimit mbstowcs_l memmove poll posix_fallocate pstat pthread_is_threaded_np readlink setproctitle setsid shm_open strsignal symlink sync_file_range uselocale utime utimes wcstombs_l
1500815008
do :
1500915009
as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
1501015010
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
@@ -15893,24 +15893,6 @@ esac
1589315893

1589415894
fi
1589515895

15896-
ac_fn_c_check_decl "$LINENO" "sys_siglist" "ac_cv_have_decl_sys_siglist" "#include <signal.h>
15897-
/* NetBSD declares sys_siglist in unistd.h. */
15898-
#ifdef HAVE_UNISTD_H
15899-
# include <unistd.h>
15900-
#endif
15901-
15902-
"
15903-
if test "x$ac_cv_have_decl_sys_siglist" = xyes; then :
15904-
ac_have_decl=1
15905-
else
15906-
ac_have_decl=0
15907-
fi
15908-
15909-
cat >>confdefs.h <<_ACEOF
15910-
#define HAVE_DECL_SYS_SIGLIST $ac_have_decl
15911-
_ACEOF
15912-
15913-
1591415896
ac_fn_c_check_func "$LINENO" "syslog" "ac_cv_func_syslog"
1591515897
if test "x$ac_cv_func_syslog" = xyes; then :
1591615898
ac_fn_c_check_header_mongrel "$LINENO" "syslog.h" "ac_cv_header_syslog_h" "$ac_includes_default"

‎configure.in

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1622,6 +1622,7 @@ AC_CHECK_FUNCS(m4_normalize([
16221622
setproctitle
16231623
setsid
16241624
shm_open
1625+
strsignal
16251626
symlink
16261627
sync_file_range
16271628
uselocale
@@ -1821,14 +1822,6 @@ if test "$PORTNAME" = "cygwin"; then
18211822
AC_LIBOBJ(dirmod)
18221823
fi
18231824

1824-
AC_CHECK_DECLS([sys_siglist], [], [],
1825-
[#include <signal.h>
1826-
/* NetBSD declares sys_siglist in unistd.h. */
1827-
#ifdef HAVE_UNISTD_H
1828-
# include <unistd.h>
1829-
#endif
1830-
])
1831-
18321825
AC_CHECK_FUNC(syslog,
18331826
[AC_CHECK_HEADER(syslog.h,
18341827
[AC_DEFINE(HAVE_SYSLOG, 1, [Define to 1 if you have the syslog interface.])])])

‎src/backend/postmaster/pgarch.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -596,17 +596,10 @@ pgarch_archiveXlog(char *xlog)
596596
errhint("See C include file \"ntstatus.h\" for a description of the hexadecimal value."),
597597
errdetail("The failed archive command was: %s",
598598
xlogarchcmd)));
599-
#elif defined(HAVE_DECL_SYS_SIGLIST) && HAVE_DECL_SYS_SIGLIST
600-
ereport(lev,
601-
(errmsg("archive command was terminated by signal %d: %s",
602-
WTERMSIG(rc),
603-
WTERMSIG(rc) < NSIG ? sys_siglist[WTERMSIG(rc)] : "(unknown)"),
604-
errdetail("The failed archive command was: %s",
605-
xlogarchcmd)));
606599
#else
607600
ereport(lev,
608-
(errmsg("archive command was terminated by signal %d",
609-
WTERMSIG(rc)),
601+
(errmsg("archive command was terminated by signal %d: %s",
602+
WTERMSIG(rc), pg_strsignal(WTERMSIG(rc))),
610603
errdetail("The failed archive command was: %s",
611604
xlogarchcmd)));
612605
#endif

‎src/backend/postmaster/postmaster.c

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3563,6 +3563,7 @@ LogChildExit(int lev, const char *procname, int pid, int exitstatus)
35633563
procname, pid, WEXITSTATUS(exitstatus)),
35643564
activity ? errdetail("Failed process was running: %s", activity) : 0));
35653565
else if (WIFSIGNALED(exitstatus))
3566+
{
35663567
#if defined(WIN32)
35673568
ereport(lev,
35683569

@@ -3573,27 +3574,18 @@ LogChildExit(int lev, const char *procname, int pid, int exitstatus)
35733574
procname, pid, WTERMSIG(exitstatus)),
35743575
errhint("See C include file \"ntstatus.h\" for a description of the hexadecimal value."),
35753576
activity ? errdetail("Failed process was running: %s", activity) : 0));
3576-
#elif defined(HAVE_DECL_SYS_SIGLIST) && HAVE_DECL_SYS_SIGLIST
3577+
#else
35773578
ereport(lev,
35783579

35793580
/*------
35803581
translator: %s is a noun phrase describing a child process, such as
35813582
"server process" */
35823583
(errmsg("%s (PID %d) was terminated by signal %d: %s",
35833584
procname, pid, WTERMSIG(exitstatus),
3584-
WTERMSIG(exitstatus) < NSIG ?
3585-
sys_siglist[WTERMSIG(exitstatus)] : "(unknown)"),
3586-
activity ? errdetail("Failed process was running: %s", activity) : 0));
3587-
#else
3588-
ereport(lev,
3589-
3590-
/*------
3591-
translator: %s is a noun phrase describing a child process, such as
3592-
"server process" */
3593-
(errmsg("%s (PID %d) was terminated by signal %d",
3594-
procname, pid, WTERMSIG(exitstatus)),
3585+
pg_strsignal(WTERMSIG(exitstatus))),
35953586
activity ? errdetail("Failed process was running: %s", activity) : 0));
35963587
#endif
3588+
}
35973589
else
35983590
ereport(lev,
35993591

‎src/bin/pg_basebackup/pg_basebackup.c

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2014,7 +2014,7 @@ BaseBackup(void)
20142014
{
20152015
#ifndef WIN32
20162016
int status;
2017-
int r;
2017+
pid_t r;
20182018
#else
20192019
DWORD status;
20202020

@@ -2042,7 +2042,7 @@ BaseBackup(void)
20422042

20432043
/* Just wait for the background process to exit */
20442044
r = waitpid(bgchild, &status, 0);
2045-
if (r == -1)
2045+
if (r == (pid_t) -1)
20462046
{
20472047
fprintf(stderr, _("%s: could not wait for child process: %s\n"),
20482048
progname, strerror(errno));
@@ -2051,19 +2051,13 @@ BaseBackup(void)
20512051
if (r != bgchild)
20522052
{
20532053
fprintf(stderr, _("%s: child %d died, expected %d\n"),
2054-
progname, r, (int) bgchild);
2054+
progname, (int) r, (int) bgchild);
20552055
disconnect_and_exit(1);
20562056
}
2057-
if (!WIFEXITED(status))
2058-
{
2059-
fprintf(stderr, _("%s: child process did not exit normally\n"),
2060-
progname);
2061-
disconnect_and_exit(1);
2062-
}
2063-
if (WEXITSTATUS(status) != 0)
2057+
if (status != 0)
20642058
{
2065-
fprintf(stderr, _("%s: child process exited with error %d\n"),
2066-
progname, WEXITSTATUS(status));
2059+
fprintf(stderr, "%s: %s\n",
2060+
progname, wait_result_to_str(status));
20672061
disconnect_and_exit(1);
20682062
}
20692063
/* Exited normally, we're happy! */

‎src/common/wait_error.c

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -56,25 +56,17 @@ wait_result_to_str(int exitstatus)
5656
}
5757
}
5858
else if (WIFSIGNALED(exitstatus))
59+
{
5960
#if defined(WIN32)
6061
snprintf(str, sizeof(str),
6162
_("child process was terminated by exception 0x%X"),
6263
WTERMSIG(exitstatus));
63-
#elif defined(HAVE_DECL_SYS_SIGLIST) && HAVE_DECL_SYS_SIGLIST
64-
{
65-
char str2[256];
66-
67-
snprintf(str2, sizeof(str2), "%d: %s", WTERMSIG(exitstatus),
68-
WTERMSIG(exitstatus) < NSIG ?
69-
sys_siglist[WTERMSIG(exitstatus)] : "(unknown)");
70-
snprintf(str, sizeof(str),
71-
_("child process was terminated by signal %s"), str2);
72-
}
7364
#else
7465
snprintf(str, sizeof(str),
75-
_("child process was terminated by signal %d"),
76-
WTERMSIG(exitstatus));
66+
_("child process was terminated by signal %d: %s"),
67+
WTERMSIG(exitstatus), pg_strsignal(WTERMSIG(exitstatus)));
7768
#endif
69+
}
7870
else
7971
snprintf(str, sizeof(str),
8072
_("child process exited with unrecognized status %d"),

‎src/include/pg_config.h.in

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,6 @@
182182
don't. */
183183
#undef HAVE_DECL_STRTOULL
184184

185-
/* Define to 1 if you have the declaration of `sys_siglist', and to 0 if you
186-
don't. */
187-
#undef HAVE_DECL_SYS_SIGLIST
188-
189185
/* Define to 1 if you have the declaration of `vsnprintf', and to 0 if you
190186
don't. */
191187
#undef HAVE_DECL_VSNPRINTF
@@ -547,6 +543,9 @@
547543
/* Define to use have a strong random number source */
548544
#undef HAVE_STRONG_RANDOM
549545

546+
/* Define to 1 if you have the `strsignal' function. */
547+
#undef HAVE_STRSIGNAL
548+
550549
/* Define to 1 if you have the `strtoll' function. */
551550
#undef HAVE_STRTOLL
552551

‎src/include/pg_config.h.win32

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,9 @@
414414
/* Define to use have a strong random number source */
415415
#define HAVE_STRONG_RANDOM 1
416416

417+
/* Define to 1 if you have the `strsignal' function. */
418+
/* #undef HAVE_STRSIGNAL */
419+
417420
/* Define to 1 if you have the `strtoll' function. */
418421
#ifdef HAVE_LONG_LONG_INT_64
419422
#define HAVE_STRTOLL 1

‎src/include/port.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,9 @@ extern int pg_printf(const char *fmt,...) pg_attribute_printf(1, 2);
189189
#endif
190190
#endif /* USE_REPL_SNPRINTF */
191191

192+
/* Wrap strsignal(), or provide our own version if necessary */
193+
extern const char *pg_strsignal(int signum);
194+
192195
/* Portable prompt handling */
193196
extern void simple_prompt(const char *prompt, char *destination, size_t destlen,
194197
bool echo);

‎src/port/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ LIBS += $(PTHREAD_LIBS)
3232

3333
OBJS = $(LIBOBJS) $(PG_CRC32C_OBJS) chklocale.o erand48.o inet_net_ntop.o \
3434
noblock.o path.o pgcheckdir.o pgmkdirp.o pgsleep.o \
35-
pgstrcasecmp.o pqsignal.o \
35+
pgstrcasecmp.o pgstrsignal.o pqsignal.o \
3636
qsort.o qsort_arg.o quotes.o sprompt.o tar.o thread.o
3737

3838
ifeq ($(enable_strong_random), yes)

0 commit comments

Comments
 (0)