MSVC: Substitute $(top_builddir) in REGRESS_OPTS.

nmisch · nmisch · commit d5e70c73bfd0 · 2014-07-23T00:36:34.000-04:00
Commit d7cdf6e introduced a usage thereof. Back-patch to 9.0, like that commit.
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
@@ -222,9 +222,13 @@ sub fetchRegressOpts
     if ($m =~ /^\s*REGRESS_OPTS\s*=(.*)/m)
     {
 
-        # ignore options that use makefile variables - can't handle those
-        # ignore anything that isn't an option staring with --
-        @opts = grep { $_ !~ /\$\(/ && $_ =~ /^--/ } split(/\s+/,$1);
+		# Substitute known Makefile variables, then ignore options that retain
+		# an unhandled variable reference.  Ignore anything that isn't an
+		# option starting with "--".
+		@opts = grep {
+			s/\Q$(top_builddir)\E/\"$topdir\"/;
+			$_ !~ /\$\(/ && $_ =~ /^--/
+		} split(/\s+/, $1);
     }
     return @opts;
 }

Original file line number	Diff line number	Diff line change
`@@ -222,9 +222,13 @@ sub fetchRegressOpts`
`222`	`222`	`if ($m =~ /^\sREGRESS_OPTS\s=(.*)/m)`
`223`	`223`	`{`
`224`	`224`
`225`		`- # ignore options that use makefile variables - can't handle those`
`226`		`- # ignore anything that isn't an option staring with --`
`227`		`- @opts = grep { $_ !~ /\$\(/ && $_ =~ /^--/ } split(/\s+/,$1);`
	`225`	`+ # Substitute known Makefile variables, then ignore options that retain`
	`226`	`+ # an unhandled variable reference. Ignore anything that isn't an`
	`227`	`+ # option starting with "--".`
	`228`	`+ @opts = grep {`
	`229`	`+ s/\Q$(top_builddir)\E/\"$topdir\"/;`
	`230`	`+ $_ !~ /\$\(/ && $_ =~ /^--/`
	`231`	`+ } split(/\s+/, $1);`
`228`	`232`	`}`
`229`	`233`	`return @opts;`
`230`	`234`	`}`