Fix description of I/O timing info for shared buffers in EXPLAIN (BUFFERS)

michaelpq · michaelpq · commit db69101a1d00 · 2023-12-14T09:59:47.000+01:00
This fixes an error introduced by efb0ef9, that changed the description of this field to "shared/local" while these I/O timings relate to shared buffers. This information is available when track_io_timing is enabled. Note that HEAD has added new counters for local buffers in 295c36c, so there is no need to touch it. The description is updated to "shared" to be compatible with HEAD. Per discussion with Nazir Bilal Yavuz and Hubert Depesz Lubaczewski, whose EXPLAIN analyzer tool was not actually able to parse the previous term because of the slash character. Discussion: https://postgr.es/m/ZTCTiUqm_H3iBihl@paquier.xyz Backpatch-through: 15
diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
@@ -3632,7 +3632,7 @@ show_buffer_usage(ExplainState *es, const BufferUsage *usage, bool planning)
 
 			if (has_timing)
 			{
-				appendStringInfoString(es->str, " shared/local");
+				appendStringInfoString(es->str, " shared");
 				if (!INSTR_TIME_IS_ZERO(usage->blk_read_time))
 					appendStringInfo(es->str, " read=%0.3f",
 									 INSTR_TIME_GET_MILLISEC(usage->blk_read_time));

Original file line number	Diff line number	Diff line change
`@@ -3632,7 +3632,7 @@ show_buffer_usage(ExplainState es, const BufferUsage usage, bool planning)`
`3632`	`3632`
`3633`	`3633`	`if (has_timing)`
`3634`	`3634`	`{`
`3635`		`- appendStringInfoString(es->str, " shared/local");`
	`3635`	`+ appendStringInfoString(es->str, " shared");`
`3636`	`3636`	`if (!INSTR_TIME_IS_ZERO(usage->blk_read_time))`
`3637`	`3637`	`appendStringInfo(es->str, " read=%0.3f",`
`3638`	`3638`	`INSTR_TIME_GET_MILLISEC(usage->blk_read_time));`