Ensure _dosmaperr() actually sets errno correctly.

tglsfdc · tglsfdc · commit ec6a6a268a63 · 2013-11-23T18:24:54.000-05:00
If logging is enabled, either ereport() or fprintf() might stomp on errno
internally, causing this function to return the wrong result.  That might
only end in a misleading error report, but in any code that's examining
errno to decide what to do next, the consequences could be far graver.

This has been broken since the very first version of this file in 2006
... it's a bit astonishing that we didn't identify this long ago.

Reported by Amit Kapila, though this isn't his proposed fix.
diff --git a/src/port/win32error.c b/src/port/win32error.c
@@ -175,14 +175,16 @@ _dosmaperr(unsigned long e)
 	{
 		if (doserrors[i].winerr == e)
 		{
-			errno = doserrors[i].doserr;
+			int			doserr = doserrors[i].doserr;
+
 #ifndef FRONTEND
 			ereport(DEBUG5,
 					(errmsg_internal("mapped win32 error code %lu to %d",
-									 e, errno)));
+									 e, doserr)));
 #elif FRONTEND_DEBUG
-			fprintf(stderr, _("mapped win32 error code %lu to %d"), e, errno);
+			fprintf(stderr, _("mapped win32 error code %lu to %d"), e, doserr);
 #endif
+			errno = doserr;
 			return;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -175,14 +175,16 @@ _dosmaperr(unsigned long e)`
`175`	`175`	`{`
`176`	`176`	`if (doserrors[i].winerr == e)`
`177`	`177`	`{`
`178`		`- errno = doserrors[i].doserr;`
	`178`	`+ int doserr = doserrors[i].doserr;`
	`179`	`+`
`179`	`180`	`#ifndef FRONTEND`
`180`	`181`	`ereport(DEBUG5,`
`181`	`182`	`(errmsg_internal("mapped win32 error code %lu to %d",`
`182`		`- e, errno)));`
	`183`	`+ e, doserr)));`
`183`	`184`	`#elif FRONTEND_DEBUG`
`184`		`- fprintf(stderr, _("mapped win32 error code %lu to %d"), e, errno);`
	`185`	`+ fprintf(stderr, _("mapped win32 error code %lu to %d"), e, doserr);`
`185`	`186`	`#endif`
	`187`	`+ errno = doserr;`
`186`	`188`	`return;`
`187`	`189`	`}`
`188`	`190`	`}`