Remove dead assignment to local variable.

hlinnaka · hlinnaka · commit f4b3ab537fe2 · 2021-07-12T11:14:08.000+03:00
This should have been removed in commit 7e30c18, which split the loop into two. Only the first loop uses the 'from' variable; updating it in the second loop is bogus. It was never read after the first loop, so this was harmless and surely optimized away by the compiler, but let's be tidy. Backpatch to all supported versions. Author: Ranier Vilela Discussion: https://www.postgresql.org/message-id/CAEudQAoWq%2BAL3BnELHu7gms2GN07k-np6yLbukGaxJ1vY-zeiQ%40mail.gmail.com
diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c
@@ -75,7 +75,6 @@ _bt_restore_page(Page page, char *from, int len)
 		if (PageAddItem(page, items[i], itemsizes[i], nitems - i,
 						false, false) == InvalidOffsetNumber)
 			elog(PANIC, "_bt_restore_page: cannot add item to page");
-		from += itemsz;
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,6 @@ _bt_restore_page(Page page, char *from, int len)`
`75`	`75`	`if (PageAddItem(page, items[i], itemsizes[i], nitems - i,`
`76`	`76`	`false, false) == InvalidOffsetNumber)`
`77`	`77`	`elog(PANIC, "_bt_restore_page: cannot add item to page");`
`78`		`- from += itemsz;`
`79`	`78`	`}`
`80`	`79`	`}`
`81`	`80`