Skip to content

Commit 0896ae5

Browse files
committed
Fix inconsistencies and typos in the tree
This is numbered take 7, and addresses a set of issues around: - Fixes for typos and incorrect reference names. - Removal of unneeded comments. - Removal of unreferenced functions and structures. - Fixes regarding variable name consistency. Author: Alexander Lakhin Discussion: https://postgr.es/m/10bfd4ac-3e7c-40ab-2b2e-355ed15495e8@gmail.com
1 parent 4c3d05d commit 0896ae5

File tree

41 files changed

+55
-84
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+55
-84
lines changed

contrib/cube/cube.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ bool g_cube_leaf_consistent(NDBOX *key, NDBOX *query, StrategyNumber strategy);
100100
bool g_cube_internal_consistent(NDBOX *key, NDBOX *query, StrategyNumber strategy);
101101

102102
/*
103-
** Auxiliary funxtions
103+
** Auxiliary functions
104104
*/
105105
static double distance_1D(double a1, double a2, double b1, double b2);
106106
static bool cube_is_point_internal(NDBOX *cube);

contrib/intarray/_int.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,12 +85,6 @@ typedef struct
8585

8686
#define GETSIGN(x) ( (BITVECP)( (char*)x+GTHDRSIZE ) )
8787

88-
/*
89-
* types for functions
90-
*/
91-
typedef ArrayType *(*formarray) (ArrayType *, ArrayType *);
92-
typedef void (*formfloat) (ArrayType *, float *);
93-
9488
/*
9589
* useful functions
9690
*/

contrib/ltree/ltxtquery_io.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ queryin(char *buf)
368368
state.str = tmp;
369369
}
370370

371-
/* set user friendly-operand view */
371+
/* set user-friendly operand view */
372372
memcpy((void *) GETOPERAND(query), (void *) state.op, state.sumlen);
373373
pfree(state.op);
374374

contrib/pgstattuple/pgstatindex.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -727,7 +727,7 @@ pgstathashindex(PG_FUNCTION_ARGS)
727727
}
728728

729729
/* -------------------------------------------------
730-
* GetHashPageStatis()
730+
* GetHashPageStats()
731731
*
732732
* Collect statistics of single hash page
733733
* -------------------------------------------------

doc/src/sgml/gist.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -922,7 +922,7 @@ my_fetch(PG_FUNCTION_ARGS)
922922
* Convert 'fetched_data' into the a Datum of the original datatype.
923923
*/
924924

925-
/* fill *retval from fetch_data. */
925+
/* fill *retval from fetched_data. */
926926
gistentryinit(*retval, PointerGetDatum(converted_datum),
927927
entry->rel, entry->page, entry->offset, FALSE);
928928

src/backend/access/gin/README

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ algorithms.
163163

164164
* The posting list can be accessed with GinGetPosting(itup)
165165

166-
* If GinITupIsCompressed(itup), the posting list is stored in compressed
166+
* If GinItupIsCompressed(itup), the posting list is stored in compressed
167167
format. Otherwise it is just an array of ItemPointers. New tuples are always
168168
stored in compressed format, uncompressed items can be present if the
169169
database was migrated from 9.3 or earlier version.

src/backend/access/gin/ginfast.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1013,7 +1013,7 @@ ginInsertCleanup(GinState *ginstate, bool full_clean,
10131013

10141014
/*
10151015
* As pending list pages can have a high churn rate, it is desirable to
1016-
* recycle them immediately to the FreeSpace Map when ordinary backends
1016+
* recycle them immediately to the FreeSpaceMap when ordinary backends
10171017
* clean the list.
10181018
*/
10191019
if (fsm_vac && fill_fsm)

src/backend/access/gist/README

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ it splits the page, and constructs the new downlink tuples for the split
170170
pages. The caller must then call gistplacetopage() on the parent page to
171171
insert the downlink tuples. The parent page that holds the downlink to
172172
the child might have migrated as a result of concurrent splits of the
173-
parent, gistfindCorrectParent() is used to find the parent page.
173+
parent, gistFindCorrectParent() is used to find the parent page.
174174

175175
Splitting the root page works slightly differently. At root split,
176176
gistplacetopage() allocates the new child pages and replaces the old root

src/backend/access/gist/gist.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,7 @@ gistdoinsert(Relation r, IndexTuple itup, Size freespace,
821821
/*
822822
* Leaf page. Insert the new key. We've already updated all the
823823
* parents on the way down, but we might have to split the page if
824-
* it doesn't fit. gistinserthere() will take care of that.
824+
* it doesn't fit. gistinserttuple() will take care of that.
825825
*/
826826

827827
/*

src/backend/access/nbtree/README

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ right sibling's left-link --- followed by a second WAL entry for the
457457
insertion on the parent level (which might itself be a page split, requiring
458458
an additional insertion above that, etc).
459459

460-
For a root split, the followon WAL entry is a "new root" entry rather than
460+
For a root split, the follow-on WAL entry is a "new root" entry rather than
461461
an "insertion" entry, but details are otherwise much the same.
462462

463463
Because splitting involves multiple atomic actions, it's possible that the

0 commit comments

Comments
 (0)