snapshot stability test

kelvich · kelvich · commit 2662ef9fdc9c · 2018-02-05T00:38:45.000+03:00
diff --git a/contrib/postgres_fdw/t/001_bank_check.pl b/contrib/postgres_fdw/t/001_bank_check.pl
@@ -3,7 +3,7 @@
 
 use PostgresNode;
 use TestLib;
-use Test::More tests => 2;
+use Test::More tests => 3;
 
 my $master = get_new_node("master");
 $master->init;
@@ -56,9 +56,6 @@
 
 $master->pgbench(-n, -c => 20, -t => 30, -f => "$TestLib::log_path/../../t/bank.sql", 'postgres' );
 
-# diag( $master->connstr() );
-# sleep(3600);
-
 ###############################################################################
 # Helpers
 ###############################################################################
@@ -162,10 +159,59 @@ sub count_and_delete_rows
 is($isolation_errors, 0, 'isolation between concurrent global and local transactions');
 
 
-# diag( $master->connstr('postgres'), "\n" );
-# diag( $shard1->connstr('postgres'), "\n" );
-# diag( $shard2->connstr('postgres'), "\n" );
-# sleep(3600);
+###############################################################################
+# Snapshot stability
+###############################################################################
+
+my ($hashes, $hash1, $hash2);
+my $stability_errors = 0;
+my $stable;
+
+# global txses
+$pgb_handle1 = $master->pgbench_async(-n, -c => 5, -T => $seconds, -f => "$TestLib::log_path/../../t/bank.sql", 'postgres' );
+# concurrent local
+$pgb_handle2 = $shard1->pgbench_async(-n, -c => 5, -T => $seconds, -f => "$TestLib::log_path/../../t/bank1.sql", 'postgres' );
+$pgb_handle3 = $shard2->pgbench_async(-n, -c => 5, -T => $seconds, -f => "$TestLib::log_path/../../t/bank2.sql", 'postgres' );
+
+$selects = 0;
+$started = time();
+while (time() - $started < $seconds)
+{
+	foreach my $node ($master, $shard1, $shard2)
+	{
+		($hash1, $_, $hash2) = split "\n", $node->safe_psql('postgres', qq[
+			begin isolation level repeatable read;
+			select md5(array_agg((t.*)::text)::text) from (select * from accounts order by id) as t;
+			select pg_sleep(1);
+			select md5(array_agg((t.*)::text)::text) from (select * from accounts order by id) as t;
+			commit;
+		]);
+
+		if ($hash1 ne $hash2)
+		{
+			$stability_errors++;
+		}
+		elsif ($hash1 eq '' or $hash2 eq '')
+		{
+			die;
+		}
+		else
+		{
+			$selects++;
+		}
+	}
+}
+
+$master->pgbench_await($pgb_handle1);
+$shard1->pgbench_await($pgb_handle2);
+$shard2->pgbench_await($pgb_handle3);
+
+die "" unless ( $selects > 0 &&
+	count_and_delete_rows($master, 'global_transactions') > 0 &&
+	count_and_delete_rows($shard1, 'local_transactions') > 0 &&
+	count_and_delete_rows($shard2, 'local_transactions') > 0);
+
+is($stability_errors, 0, 'snapshot is stable during concurrent global and local transactions');
 
 $master->stop;
 $shard1->stop;
diff --git a/contrib/postgres_fdw/t/bank1.sql b/contrib/postgres_fdw/t/bank1.sql
@@ -4,5 +4,4 @@ BEGIN;
 WITH upd AS (UPDATE accounts SET amount = amount - 1 WHERE id = (2*:id + 1) RETURNING *)
     INSERT into local_transactions SELECT now() FROM upd;
 UPDATE accounts SET amount = amount + 1 WHERE id = (2*:id + 3);
--- INSERT into local_transactions values(now());
 COMMIT;
diff --git a/contrib/postgres_fdw/t/bank2.sql b/contrib/postgres_fdw/t/bank2.sql
@@ -4,5 +4,4 @@ BEGIN;
 WITH upd AS (UPDATE accounts SET amount = amount - 1 WHERE id = 2*:id RETURNING *)
     INSERT into local_transactions SELECT now() FROM upd;
 UPDATE accounts SET amount = amount + 1 WHERE id = (2*:id + 2);
--- INSERT into local_transactions values(now());
 COMMIT;
