Start transaction in origin message

PJMODOS · PJMODOS · commit 493461d85460 · 2016-01-15T17:13:07.000+01:00
We don't start new transactions in begin message to not have to replay
empty transactions but in order to work with origins we have to be
inside a transaction, so start it in origin message which always comes
right after begin and before any DML message.
diff --git a/pglogical_apply.c b/pglogical_apply.c
@@ -231,6 +231,9 @@ handle_origin(StringInfo s)
 	if (!in_remote_transaction || IsTransactionState())
 		elog(ERROR, "ORIGIN message sent out of order");
 
+	/* We have to start transaction here so that we can work with origins. */
+	ensure_transaction();
+
 	origin = pglogical_read_origin(s, &remote_origin_lsn);
 	remote_origin_id = replorigin_by_name(origin, false);
 }

Original file line number	Diff line number	Diff line change
`@@ -231,6 +231,9 @@ handle_origin(StringInfo s)`
`231`	`231`	`if (!in_remote_transaction \|\| IsTransactionState())`
`232`	`232`	`elog(ERROR, "ORIGIN message sent out of order");`
`233`	`233`
	`234`	`+ /* We have to start transaction here so that we can work with origins. */`
	`235`	`+ ensure_transaction();`
	`236`	`+`
`234`	`237`	`origin = pglogical_read_origin(s, &remote_origin_lsn);`
`235`	`238`	`remote_origin_id = replorigin_by_name(origin, false);`
`236`	`239`	`}`