Skip to content

Commit c219d9b

Browse files
alvherrealvherre
committed
Split tuple struct defs from htup.h to htup_details.h
This reduces unnecessary exposure of other headers through htup.h, which is very widely included by many files. I have chosen to move the function prototypes to the new file as well, because that means htup.h no longer needs to include tupdesc.h. In itself this doesn't have much effect in indirect inclusion of tupdesc.h throughout the tree, because it's also required by execnodes.h; but it's something to explore in the future, and it seemed best to do the htup.h change now while I'm busy with it.
1 parent 381a9ed commit c219d9b

File tree

167 files changed

+830
-639
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

167 files changed

+830
-639
lines changed

‎contrib/dblink/dblink.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,14 @@
3535
#include <limits.h>
3636

3737
#include "libpq-fe.h"
38-
#include "funcapi.h"
38+
39+
#include "access/htup_details.h"
3940
#include "catalog/indexing.h"
4041
#include "catalog/namespace.h"
4142
#include "catalog/pg_type.h"
4243
#include "executor/spi.h"
4344
#include "foreign/foreign.h"
45+
#include "funcapi.h"
4446
#include "lib/stringinfo.h"
4547
#include "mb/pg_wchar.h"
4648
#include "miscadmin.h"

‎contrib/file_fdw/file_fdw.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
#include <sys/stat.h>
1616
#include <unistd.h>
1717

18+
#include "access/htup_details.h"
1819
#include "access/reloptions.h"
1920
#include "access/sysattr.h"
2021
#include "catalog/pg_foreign_table.h"

‎contrib/hstore/hstore_io.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
#include <ctype.h>
77

8+
#include "access/htup_details.h"
89
#include "catalog/pg_type.h"
910
#include "funcapi.h"
1011
#include "libpq/pqformat.h"

‎contrib/hstore/hstore_op.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
#include "postgres.h"
55

66
#include "access/hash.h"
7+
#include "access/htup_details.h"
78
#include "catalog/pg_type.h"
89
#include "funcapi.h"
910
#include "utils/builtins.h"

‎contrib/ltree/ltree_op.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
#include <ctype.h>
99

10+
#include "access/htup_details.h"
1011
#include "catalog/pg_statistic.h"
1112
#include "utils/builtins.h"
1213
#include "utils/lsyscache.h"

‎contrib/pageinspect/heapfuncs.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525

2626
#include "postgres.h"
2727

28+
#include "access/htup_details.h"
2829
#include "funcapi.h"
2930
#include "utils/builtins.h"
3031
#include "miscadmin.h"

‎contrib/pageinspect/rawpage.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
#include "postgres.h"
1717

18+
#include "access/htup_details.h"
1819
#include "catalog/catalog.h"
1920
#include "catalog/namespace.h"
2021
#include "funcapi.h"

‎contrib/pg_buffercache/pg_buffercache_pages.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
*/
99
#include "postgres.h"
1010

11+
#include "access/htup_details.h"
1112
#include "catalog/pg_type.h"
1213
#include "funcapi.h"
1314
#include "storage/buf_internals.h"

‎contrib/tablefunc/tablefunc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434

3535
#include <math.h>
3636

37+
#include "access/htup_details.h"
3738
#include "catalog/pg_type.h"
3839
#include "executor/spi.h"
3940
#include "funcapi.h"

‎contrib/tcn/tcn.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
#include "postgres.h"
1717

18+
#include "access/htup_details.h"
1819
#include "executor/spi.h"
1920
#include "commands/async.h"
2021
#include "commands/trigger.h"

0 commit comments

Comments
 (0)