rethink idea of change data dir to just start node with custom data dir

Stepan Neretin · Stepan Neretin · commit 7dd98fe32d6c · 2025-03-12T14:44:42.000+07:00
diff --git a/testgres/node.py b/testgres/node.py
@@ -315,15 +315,7 @@ def logs_dir(self):
 
     @property
     def data_dir(self):
-        # NOTE: we can't run initdb without user's args
-        if hasattr(self, '_data_dir'):
-            return self._data_dir
-        else:
-            return os.path.join(self.base_dir, DATA_DIR)
-
-    @data_dir.setter
-    def data_dir(self, value):
-        self._data_dir = value
+        return os.path.join(self.base_dir, DATA_DIR)
 
     @property
     def utils_log_file(self):
@@ -726,7 +718,7 @@ def get_control_data(self):
 
         return out_dict
 
-    def slow_start(self, replica=False, dbname='template1', username=None, max_attempts=0):
+    def slow_start(self, replica=False, dbname='template1', username=None, max_attempts=0, custom_data_dir=None):
         """
         Starts the PostgreSQL instance and then polls the instance
         until it reaches the expected state (primary or replica). The state is checked
@@ -739,7 +731,7 @@ def slow_start(self, replica=False, dbname='template1', username=None, max_attem
                         If False, waits for the instance to be in primary mode. Default is False.
                max_attempts:
         """
-        self.start()
+        self.start(custom_data_dir=custom_data_dir)
 
         if replica:
             query = 'SELECT pg_is_in_recovery()'
@@ -771,7 +763,7 @@ def _detect_port_conflict(self, log_files0, log_files1):
                 return True
         return False
 
-    def start(self, params=[], wait=True):
+    def start(self, params=[], wait=True, custom_data_dir=None):
         """
         Starts the PostgreSQL node using pg_ctl if node has not been started.
         By default, it waits for the operation to complete before returning.
@@ -792,7 +784,7 @@ def start(self, params=[], wait=True):
             return self
 
         _params = [self._get_bin_path("pg_ctl"),
-                   "-D", self.data_dir,
+                   "-D", custom_data_dir if custom_data_dir else self.data_dir,
                    "-l", self.pg_log_file,
                    "-w" if wait else '-W',  # --wait or --no-wait
                    "start"] + params  # yapf: disable
@@ -868,7 +860,7 @@ def LOCAL__raise_cannot_start_node__std(from_exception):
         self.is_started = True
         return self
 
-    def stop(self, params=[], wait=True):
+    def stop(self, params=[], wait=True, custom_data_dir=None):
         """
         Stops the PostgreSQL node using pg_ctl if the node has been started.
 
@@ -884,7 +876,7 @@ def stop(self, params=[], wait=True):
 
         _params = [
             self._get_bin_path("pg_ctl"),
-            "-D", self.data_dir,
+            "-D", custom_data_dir if custom_data_dir else self.data_dir,
             "-w" if wait else '-W',  # --wait or --no-wait
             "stop"
         ] + params  # yapf: disable
