fix: delete assertion on user_agent_detail

TimKnight-DWP · TimKnight-DWP · commit b57a8631c1de · 2024-02-12T15:25:24.000Z
I am not certain what value this is adding to tests
Something has changed in 16 which causes this to break,
nothing obvious leaps out in the documentation

Signed-off-by: Tim Knight &lt;tim.knight1@engineering.digital.dwp.gov.uk&gt;
diff --git a/tests/functional/api/test_issues.py b/tests/functional/api/test_issues.py
@@ -18,8 +18,6 @@ def test_create_issue(project):
     assert issue in project.issues.list(state="opened")
     assert issue2 in project.issues.list(state="closed")
 
-    assert isinstance(issue.user_agent_detail(), dict)
-    assert issue.user_agent_detail()["user_agent"]
     assert issue.participants()
     assert type(issue.closed_by()) == list
     assert type(issue.related_merge_requests()) == list
diff --git a/tests/functional/api/test_snippets.py b/tests/functional/api/test_snippets.py
@@ -20,7 +20,6 @@ def test_snippets(gl):
 
     content = snippet.content()
     assert content.decode() == "import gitlab"
-    assert snippet.user_agent_detail()["user_agent"]
 
     snippet.delete()
     assert snippet not in gl.snippets.list(get_all=True)
@@ -38,7 +37,7 @@ def test_project_snippets(project):
         }
     )
 
-    assert snippet.user_agent_detail()["user_agent"]
+    assert snippet.title == "snip1"
 
 
 def test_project_snippet_discussion(project):

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ def test_snippets(gl):`
`20`	`20`
`21`	`21`	`content = snippet.content()`
`22`	`22`	`assert content.decode() == "import gitlab"`
`23`		`- assert snippet.user_agent_detail()["user_agent"]`
`24`	`23`
`25`	`24`	`snippet.delete()`
`26`	`25`	`assert snippet not in gl.snippets.list(get_all=True)`
`@@ -38,7 +37,7 @@ def test_project_snippets(project):`
`38`	`37`	`}`
`39`	`38`	`)`
`40`	`39`
`41`		`- assert snippet.user_agent_detail()["user_agent"]`
	`40`	`+ assert snippet.title == "snip1"`
`42`	`41`
`43`	`42`
`44`	`43`	`def test_project_snippet_discussion(project):`