Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ruby/ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ruby/ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: refactor-fl-exivar
Choose a head ref
  • 4 commits
  • 13 files changed
  • 2 contributors

Commits on Jun 13, 2025

  1. Enforce consistency between shape_id and FL_EXIVAR 

    The FL_EXIVAR is a bit redundant with the shape_id.
Now that the `shape_id` is embedded in all objects on all archs,
we can cheaply check if an object has any fields with a simple
bitmask.
    @byroot
    byroot committed Jun 13, 2025
    Configuration menu
    Copy the full SHA
    3f21491 View commit details
    Browse the repository at this point in the history

  2. Use the shape_id rather than FL_EXIVAR 

    We still keep setting `FL_EXIVAR` so that `rb_shape_verify_consistency`
can detect discrepancies.
    @byroot
    byroot committed Jun 13, 2025
    Configuration menu
    Copy the full SHA
    61a9a2a View commit details
    Browse the repository at this point in the history

  3. Get rid of FL_EXIVAR 

    Now that the shape_id gives us all the same information, it's no
longer needed.
    @byroot
    byroot committed Jun 13, 2025
    Configuration menu
    Copy the full SHA
    268cb75 View commit details
    Browse the repository at this point in the history

  4. Suppress unused-variable warning

    @nobu @byroot
    nobu authored and byroot committed Jun 13, 2025
    Configuration menu
    Copy the full SHA
    a9de3c6 View commit details
    Browse the repository at this point in the history
Loading