Skip to content

Change defaults for delayed payment methods. #11001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Change defaults for delayed payment methods. #11001

wants to merge 1 commit into from

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

The current default is different than web, and can be hard to debug / confusing.

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-3666

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025 •
edited
Loading

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │   0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │   0 B │   457 KiB │   457 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │   0 B │   7.4 KiB │   7.4 KiB │  0 B 
    other │  95.8 KiB │  95.8 KiB │ +10 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.8 MiB │   9.8 MiB │ +10 B │  21.8 MiB │  21.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20682 │ 20682 │ 0 (+0 -0) 
   types │  6503 │  6503 │ 0 (+0 -0) 
 classes │  5266 │  5266 │ 0 (+0 -0) 
 methods │ 31511 │ 31511 │ 0 (+0 -0) 
  fields │ 18239 │ 18239 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3646 │ 3646 │  0
APK 
    compressed    │   uncompressed   │                                           
──────────┬───────┼───────────┬──────┤                                           
 size     │ diff  │ size      │ diff │ path                                      
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 25.9 KiB │  +6 B │  64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │  +4 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    272 B │  +1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 29.2 KiB │  -1 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 56.5 KiB │ +10 B │ 130.5 KiB │  0 B │ (total)

@jaynewstrom-stripe jaynewstrom-stripe force-pushed the jaynewstrom/delayed_PM branch 4 times, most recently from 4f88e8f to bf94966 Compare June 25, 2025 18:52
@cttsai-stripe
Copy link
Contributor

We should also change the comments for allowsDelayedPaymentMethods to Defaults to true in both PaymentSheet and EmbeddedPaymentElement

cttsai-stripe
cttsai-stripe previously approved these changes Jun 25, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cttsai-stripe cttsai-stripe cttsai-stripe approved these changes

Assignees
No one assigned
Labels
v25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaynewstrom-stripe @cttsai-stripe