Skip to content

[BDCC] Disable Bank payments on missing billing details. #11039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: carlosmuvi/bdcc-collect-email-name-phone
Choose a base branch
from
Draft

[BDCC] Disable Bank payments on missing billing details. #11039

wants to merge 1 commit into from

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Jun 30, 2025 •
edited
Loading

Summary

  • Parse billing details in ConsumerPaymentDetails.Bank
  • Disable these payments if they miss required billing details.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/bdcc-disable-bank-payments branch from 1f6a200 to 453d6bf Compare June 30, 2025 16:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├──────────┬──────────┬──────────┼───────────┬───────────┬────────
 APK      │ old      │ new      │ diff     │ old       │ new       │ diff   
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼────────
      dex │  4.4 MiB │  4.4 MiB │ +1.3 KiB │   9.8 MiB │   9.8 MiB │ +2 KiB 
     arsc │  2.5 MiB │  2.5 MiB │      0 B │   2.5 MiB │   2.5 MiB │    0 B 
 manifest │  5.7 KiB │  5.7 KiB │      0 B │  29.4 KiB │  29.4 KiB │    0 B 
      res │  918 KiB │  918 KiB │      0 B │   1.5 MiB │   1.5 MiB │    0 B 
   native │  3.5 MiB │  3.5 MiB │      0 B │   8.5 MiB │   8.5 MiB │    0 B 
    asset │  1.6 MiB │  1.6 MiB │    +13 B │   1.6 MiB │   1.6 MiB │  +13 B 
    other │  198 KiB │  198 KiB │     -4 B │ 373.9 KiB │ 373.9 KiB │    0 B 
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼────────
    total │ 13.2 MiB │ 13.2 MiB │ +1.3 KiB │  24.3 MiB │  24.3 MiB │ +2 KiB 

         │         raw          │              unique               
         ├───────┬───────┬──────┼───────┬───────┬───────────────────
 DEX     │ old   │ new   │ diff │ old   │ new   │ diff              
─────────┼───────┼───────┼──────┼───────┼───────┼───────────────────
   files │     2 │     2 │    0 │       │       │                   
 strings │ 48003 │ 47986 │  -17 │ 46726 │ 46727 │  +1 (+28 -27)     
   types │ 17041 │ 17026 │  -15 │ 16426 │ 16422 │  -4 (+14 -18)     
 classes │ 13853 │ 13849 │   -4 │ 13853 │ 13849 │  -4 (+6 -10)      
 methods │ 68444 │ 68426 │  -18 │ 67582 │ 67573 │  -9 (+1101 -1110) 
  fields │ 45255 │ 45258 │   +3 │ 44993 │ 45003 │ +10 (+1125 -1115) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6323 │ 6323 │  0
APK 
      compressed      │    uncompressed    │                               
───────────┬──────────┼───────────┬────────┤                               
 size      │ diff     │ size      │ diff   │ path                          
───────────┼──────────┼───────────┼────────┼───────────────────────────────
   4.3 MiB │ +2.1 KiB │   9.5 MiB │ +4 KiB │ ∆ classes.dex                 
 138.1 KiB │   -872 B │ 310.9 KiB │ -2 KiB │ ∆ classes2.dex                
   8.6 KiB │    +13 B │   8.4 KiB │  +13 B │ ∆ assets/dexopt/baseline.prof 
  51.4 KiB │     -3 B │ 121.7 KiB │    0 B │ ∆ META-INF/MANIFEST.MF        
  54.8 KiB │     -1 B │ 121.7 KiB │    0 B │ ∆ META-INF/CERT.SF            
───────────┼──────────┼───────────┼────────┼───────────────────────────────
   4.6 MiB │ +1.3 KiB │  10.1 MiB │ +2 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   46726 │ 46727 │ +1 (+28 -27) 
  
  + , billingPhone=
  + , contactInformationForm=
  + , linkAccount=
  + ContactInformationChanged(contactInformation=
  + LA8/e4;
  + LA8/f4;
  + LA8/g4;
  + LA8/h4;
  + LZ5/n;
  + Lf6/o;
  + VLLIZLLLL
  + VLLLLZZLLLLLLLLLLLLL
  + VLLZLLLIILLLL
  + VZLLLLLLILLLLI
  + VZLLLLLLILLLLLI
  + [LA8/D1;
  + [LA8/E3;
  + [LA8/F3;
  + [LA8/K3;
  + [LM7/n;
  + [LM7/q;
  + [LM7/r;
  + [LZ7/Q0;
  + applicationSupplier
  + contactInformation
  + contactInformationEntry
  + null cannot be cast to non-null type com.stripe.android.uicore.elements.SectionElement
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"2842a57","r8-mode":"full","version":"8.8.34"}
  
  - EnterManually(addressDetails=
  - GoBack(addressDetails=
  - LM7/X;
  - LM7/Y;
  - LM7/Z;
  - LM7/a0;
  - LM7/b0;
  - LM7/c0;
  - LM7/d0;
  - LZ7/T0;
  - Le8/j;
  - Ln8/i;
  - VIILLLZ
  - VLLIZLLL
  - VLLLLZZLLLLLLLLLLL
  - VLLZLIILLLLLL
  - VZLLLLLILLLI
  - VZLLLLLILLLLI
  - [LA8/A3;
  - [LA8/B3;
  - [LA8/C3;
  - [LA8/z1;
  - [LM7/k;
  - [LM7/l;
  - [LM7/p;
  - [LZ7/S0;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"13b1496","r8-mode":"full","version":"8.8.34"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   16426 │ 16422 │ -4 (+14 -18) 
  
  + LA8/e4;
  + LA8/f4;
  + LA8/g4;
  + LA8/h4;
  + LZ5/n;
  + Lf6/o;
  + [LA8/D1;
  + [LA8/E3;
  + [LA8/F3;
  + [LA8/K3;
  + [LM7/n;
  + [LM7/q;
  + [LM7/r;
  + [LZ7/Q0;
  
  - LM7/X;
  - LM7/Y;
  - LM7/Z;
  - LM7/a0;
  - LM7/b0;
  - LM7/c0;
  - LM7/d0;
  - LZ7/T0;
  - Le8/j;
  - Ln8/i;
  - [LA8/A3;
  - [LA8/B3;
  - [LA8/C3;
  - [LA8/z1;
  - [LM7/k;
  - [LM7/l;
  - [LM7/p;
  - [LZ7/S0;
  

METHODS:

   old   │ new   │ diff             
  ───────┼───────┼──────────────────
   67582 │ 67573 │ -9 (+1101 -1110) 
  
  + A8.A0 <init>(b)
  + A8.A0 equals(Object) → boolean
  + A8.A0 hashCode() → int
  + A8.A0 toString() → String
  + A8.A1 <clinit>()
  + A8.A2 <clinit>()
  + A8.A2 a(Function0, p, int)
  + A8.A2 b(String, E2, boolean, boolean, Function0, p, int)
  + A8.A2 c(E2, boolean, a, p, int)
  + A8.A2 d(String, boolean, boolean, p, E2, Function0, Function0, p, int, int)
  + A8.A2 e(Function0, p, int)
  + A8.A2 f(String, boolean, boolean, p, int)
  + A8.A2 g(p, p, int)
  + A8.B0 <clinit>()
  + A8.B0 equals(Object) → boolean
  + A8.B0 hashCode() → int
  + A8.B0 toString() → String
  + A8.B1 <clinit>()
  + A8.B2 <clinit>()
  + A8.B3 <init>(SepaMandateActivity, int)
  + A8.B3 b() → Object
  + A8.B <init>(List, p, P, T, boolean, Function0, Function1, Function1, C, n0, p, int)
  + A8.B <init>(boolean, u, S0, U0, o, C0, List, int, Function1, Function1, Function1, Function1, int)
  + A8.C0 <clinit>()
  + A8.C0 equals(Object) → boolean
  + A8.C0 hashCode() → int
  + A8.C0 toString() → String
  + A8.C1 <clinit>()
  + A8.C2 equals(Object) → boolean
  + A8.C2 hashCode() → int
  + A8.C2 toString() → String
  + A8.C3 <init>(SepaMandateActivity, String, int)
  + A8.C3 <init>(String, SepaMandateActivity)
  + A8.C3 g(Object, Object) → Object
  + A8.D0 <init>(G0, ContinuationImpl)
  + A8.D0 q(Object) → Object
  + A8.D1 <clinit>()
  + A8.D1 valueOf(String) → D1
  + A8.D1 values() → D1[]
  + A8.D2 <clinit>()
  + A8.D2 a(c, boolean, boolean, a, S0, t0, Function1, Function1) → i0
  + A8.D3 <init>(int)
  + A8.D3 createFromParcel(Parcel) → Object
  + A8.D3 newArray(int) → Object[]
  + A8.E0 <init>(G0, Continuation)
  + A8.E1 <init>(e, c, Y, V, c, t, c, p, int)
  + A8.E1 <init>(C, Object, Object, Object, Function, Object, Function0, Object, int, int)
  + A8.E1 <init>(p, s, T, Function0, Function0, Function0, Function0, Function0, int)
  + A8.E1 g(Object, Object) → Object
  + A8.E3 <init>(String)
  + A8.E3 describeContents() → int
  + A8.E3 equals(Object) → boolean
  + A8.E3 hashCode() → int
  + A8.E3 toString() → String
  + A8.E3 writeToParcel(Parcel, int)
  + A8.F0 <init>(G0, Continuation)
  + A8.F0 g(Object, Object) → Object
  + A8.F0 m(Object, Continuation) → Continuation
  + A8.F0 q(Object) → Object
  + A8.F1 <init>(e, Context, a0)
  + A8.F1 f(Object, Object, Object) → Object
  + A8.F2 <init>(float, float, float)
  + A8.F2 equals(Object) → boolean
  + A8.F2 hashCode() → int
  + A8.F2 toString() → String
  + A8.F3 <clinit>()
  + A8.F3 describeContents() → int
  + A8.F3 writeToParcel(Parcel, int)
  + A8.F <init>(S0,
...✂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carlosmuvi-stripe