[Console] Better error handling when misuse of ArgvInput with arrays

symfonyaml · symfonyaml · commit 86b7728e6c50 · 2024-03-04T13:20:18.000+01:00
diff --git a/src/Symfony/Component/Console/Input/ArgvInput.php b/src/Symfony/Component/Console/Input/ArgvInput.php
@@ -47,6 +47,10 @@ public function __construct(?array $argv = null, ?InputDefinition $definition =
     {
         $argv = $argv ?? $_SERVER['argv'] ?? [];
 
+        if (array_filter($argv, 'is_array')) {
+            throw new RuntimeException('Argument values expected to be all scalars, got array.');
+        }
+
         // strip the application name
         array_shift($argv);
 
diff --git a/src/Symfony/Component/Console/Tests/Input/ArgvInputTest.php b/src/Symfony/Component/Console/Tests/Input/ArgvInputTest.php
@@ -327,6 +327,11 @@ public static function provideInvalidInput()
                 new InputDefinition([new InputArgument('name', InputArgument::REQUIRED)]),
                 'Too many arguments, expected arguments "name".',
             ],
+            [
+                ['cli.php', ['array']],
+                new InputDefinition(),
+                'Argument values expected to be all scalars, got array.',
+            ],
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,10 @@ public function __construct(?array $argv = null, ?InputDefinition $definition =`
`47`	`47`	`{`
`48`	`48`	`$argv = $argv ?? $_SERVER['argv'] ?? [];`
`49`	`49`
	`50`	`+ if (array_filter($argv, 'is_array')) {`
	`51`	`+ throw new RuntimeException('Argument values expected to be all scalars, got array.');`
	`52`	`+ }`
	`53`	`+`
`50`	`54`	`// strip the application name`
`51`	`55`	`array_shift($argv);`
`52`	`56`