Skip to content

BC break between symfony/serializer 6.4.22 and 6.4.23 #60957

Closed
@loevgaard

Description

@loevgaard

Symfony version(s) affected

6.4.23

Description

In version 6.4.23 you have this method: https://github.com/symfony/symfony/blob/v6.4.23/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php#L769 where return types are added.

In version 6.4.22 you have the same method here: https://github.com/symfony/symfony/blob/v6.4.22/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php#L223 where there are no return types.

I know this technically isn't a BC break, but in practice and lot of normalizers will extend the AbstractObjectNormalizer (and override the getAllowedAttributes method) and hence it will break some applications. In this case it breaks Sylius applications.

How to reproduce

Not relevant

Possible Solution

Remove the return types from this line: https://github.com/symfony/symfony/blob/v6.4.23/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php#L769

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions