Skip to content

Bug: no-misused-promises ignores conversion of Promise to void for generic higher-order-functions with fixed type parameter #8054

Closed
@mx-bernhard

Description

@mx-bernhard

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.3.2&fileType=.ts&code=C4TwDgpgBAqgdgazgewO5wM4DECucDGUAvFABQB0lAhgE4DmGAXFHkmnANoC6AlMQHwtEKdAG4AUONCQoAJQjAcNTADVkASwAmxMnyKCAbhs0TxmiPgA2taPmSZgLDBADCVS5YBGVfAkbioKAAeABVcAmB1eygIAA9gCDhNDFhhdmw8fEFSADM4ZjDMyPs9QUKIqLhTcysbKDsHJ1d3Lx8EeUVldTg6NS1maQhkHKa3D29fII6lVWN%2BUxxnMdbfaa6evs1SUioMEAJdASgAbygAXx4eUSgAehv65BoaC2BJRebxtqmFGYxN-h2ewOpFKJ3OV1u9wwAAtkDhLNpPNBnmBHgltLsoKgIB5xEA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oFtLlZkiACa1i0Dr0GoMAbXDYciaOOiQANPIVYF2SGQAWiMgGtkANQ6UhAJUT5Y0JujD44iTdgC%2BHgLrzvnkA&tsconfig=&tokens=false

Repro Code

type UnknownsFunc = (...args: unknown[]) => unknown;

type ReturnsVoid = () => void;

declare const useCallback:
  <TFunction extends UnknownsFunc> (fn: TFunction) => TFunction;

declare const useCallbackReturningVoid: typeof useCallback<ReturnsVoid>;

useCallbackReturningVoid((async () => { })); // correct

useCallback<ReturnsVoid>(async () => { }); // should be reported as well

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/no-misused-promises": [
      "error",
      {
        "checksVoidReturn": true
      }
    ]
  }
};

tsconfig

{
}

Expected Result

Line 14 should be reported as well since it is the exact same effective type as line 12 because the generic type parameter has been provided in both cases, thus restricting the functions to void returning functions.

Actual Result

Line 14 is not reported.

Additional Info

As a workaround, we will be using restricted types similar to typeof useCallback<Fn> in our code base.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions