Skip to content

Enhancement: Remove IsNullableTypeOptions from type-utils #8931

Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

ast-spec

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

Following #8089: we noticed that the IsNullableTypeOptions interface is never actually used in the places it's taken in, such as the isNullableType function later in the file:

export interface IsNullableTypeOptions {
/**
* @deprecated - this flag no longer does anything and will be removed in the next major
*/
isReceiver?: boolean;
/**
* @deprecated - this flag no longer does anything and will be removed in the next major
*/
allowUndefined?: boolean;
}

We wanted to delete the unused interface, but doing so would be a breaking change. Now that we're working on v8 it's time - let's delete the code! 🔪

Additional Info

Note that the PR for this should be targeted against the v8 branch.

💖

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedenhancementNew feature or requestgood first issueGood for newcomerslocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions