Skip to content

Docs: Decide how we want to use '1 approval' and 'team assigned' labels #9423

Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Before You File a Documentation Request Please Confirm You Have Done The Following...

Suggested Changes

Since we added new committer team members earlier this year, we've been making more liberal use of two labels:

  • 1 approval: which can mean either or both of:
    • Ready to go whenever someone wants to merge
    • Waiting for a second team approval
  • team assigned: an alternative to accepting prs that roughly means the same thing, but with the stipulation that someone on the team should be the one to send a PR

1 approval is only lightly documented. team assigned is new and hasn't been documented at all. We've had some private chats about how we'd like to clarify at least the processes around 1 approval.

Affected URL(s)

https://typescript-eslint.io/maintenance/pull-requests

Metadata

Metadata

Labels

documentationDocumentation ("docs") that needs adding/updatinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.team assignedA member of the typescript-eslint team should work on this.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions