Skip to content

Enhancement: [no-floating-promises] Disable checkThenables by default in v8 #9508

Closed
@JoshuaKGoldberg

Description

@JoshuaKGoldberg

Before You File a Proposal Please Confirm You Have Done The Following...

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://v8--typescript-eslint.netlify.app/rules/no-floating-promises

Description

Following #8433 -> #9263: we'd resolved to add a new checkThenables option to the no-floating-promises rule. It's enabled by default in v7 to avoid a breaking change. But for v8 we'd like to disable it by default.

Fail

/* @typescript-eslint/no-floating-promises: ["error", { "checkThenables": true }] */

interface MyThenable extends PromiseLike<string> {}

declare function createMyThenable(): Promise<string>;

createMyThenable();

Pass

interface MyThenable extends PromiseLike<string> {}

declare function createMyThenable(): MyThenable;

createMyThenable();

Additional Info

💖

Metadata

Metadata

Labels

enhancement: plugin rule optionNew rule option for an existing eslint-plugin rulelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginteam assignedA member of the typescript-eslint team should work on this.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions